Issue 17225: Mask a UMR caused by ScriptShape.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17225: Mask a UMR caused by ScriptShape. (Closed)

Created:
11 years, 11 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews, brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mask a UMR caused by ScriptShape. BUG=5309 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7650

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	third_party/WebKit/WebCore/platform/graphics/chromium/UniscribeHelper.cpp	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eroman

Unfortunately I can't use MemoryDebug::MarkAsInitialized() since that would add a dependency on base/ from third_party/WebKit. ...

11 years, 11 months ago (2009-01-07 01:35:12 UTC) #1

Erik does not do reviews

11 years, 11 months ago (2009-01-07 01:57:31 UTC) #2

LGTM

For future reference, maintaining filters isn't the end of the world as long as
we're sure that this is a real false positive (as we are here) and we don't
think the filter is likely to mask another real bug in the future.  Since the
code in question is complex, I think the chance of masking is not tiny, so I
think that it's OK to do this ZeroMemory approach.  For simpler, more isolated
cases, I think a filter is fine.

Expand Messages | Collapse Messages