OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Presubmit script for Chromium JS resources. | 5 """Presubmit script for Chromium JS resources. |
6 | 6 |
7 See chrome/browser/PRESUBMIT.py | 7 See chrome/browser/PRESUBMIT.py |
8 """ | 8 """ |
9 | 9 |
10 import regex_check | 10 import regex_check |
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
83 # TODO(tbreisacher): Once we've cleaned up the style nits in all of | 83 # TODO(tbreisacher): Once we've cleaned up the style nits in all of |
84 # resources/ we can get rid of this function. | 84 # resources/ we can get rid of this function. |
85 path = self.input_api.os_path | 85 path = self.input_api.os_path |
86 resources = path.join(self.input_api.PresubmitLocalPath(), 'resources') | 86 resources = path.join(self.input_api.PresubmitLocalPath(), 'resources') |
87 dirs = ( | 87 dirs = ( |
88 path.join(resources, 'bookmark_manager'), | 88 path.join(resources, 'bookmark_manager'), |
89 path.join(resources, 'extensions'), | 89 path.join(resources, 'extensions'), |
90 path.join(resources, 'file_manager'), | 90 path.join(resources, 'file_manager'), |
91 path.join(resources, 'help'), | 91 path.join(resources, 'help'), |
92 path.join(resources, 'history'), | 92 path.join(resources, 'history'), |
93 path.join(resources, 'memory_internals'), | |
94 path.join(resources, 'net_export'), | 93 path.join(resources, 'net_export'), |
95 path.join(resources, 'net_internals'), | 94 path.join(resources, 'net_internals'), |
96 path.join(resources, 'network_action_predictor'), | 95 path.join(resources, 'network_action_predictor'), |
97 path.join(resources, 'ntp4'), | 96 path.join(resources, 'ntp4'), |
98 path.join(resources, 'options'), | 97 path.join(resources, 'options'), |
99 path.join(resources, 'password_manager_internals'), | 98 path.join(resources, 'password_manager_internals'), |
100 path.join(resources, 'print_preview'), | 99 path.join(resources, 'print_preview'), |
101 path.join(resources, 'profiler'), | 100 path.join(resources, 'profiler'), |
102 path.join(resources, 'sync_promo'), | 101 path.join(resources, 'sync_promo'), |
103 path.join(resources, 'tracing'), | 102 path.join(resources, 'tracing'), |
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
245 results.append(self._MakeErrorOrWarning( | 244 results.append(self._MakeErrorOrWarning( |
246 '\n'.join(error_lines), f.AbsoluteLocalPath())) | 245 '\n'.join(error_lines), f.AbsoluteLocalPath())) |
247 | 246 |
248 if results: | 247 if results: |
249 results.append(self.output_api.PresubmitNotifyResult( | 248 results.append(self.output_api.PresubmitNotifyResult( |
250 'See the JavaScript style guide at ' | 249 'See the JavaScript style guide at ' |
251 'http://www.chromium.org/developers/web-development-style-guide' | 250 'http://www.chromium.org/developers/web-development-style-guide' |
252 '#TOC-JavaScript')) | 251 '#TOC-JavaScript')) |
253 | 252 |
254 return results | 253 return results |
OLD | NEW |