Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1722473002: Allow intish and floatish to be coerced by heap assignment. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow intish and floatish to be coerced by heap assignment. When assigning to an integer view of the heap an intish value does not need to be collapsed with |0. Similarly a floatish value does not need to be collapsed with fround when assigned to a float view of the heap. i32[0] = i32_1 + i32_2; // ok f32[0] = f32_1 + f32_2; // ok However, floatish values cannot be safely assigned to double arrays. f64[0] = f32_1 + f32_2; // not ok BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm,test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/7e805faa30ca258cc62fca07f3e1f73026eb0401 Cr-Commit-Position: refs/heads/master@{#34206}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -5 lines) Patch
M src/typing-asm.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 2 chunks +67 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bradnelson
4 years, 10 months ago (2016-02-22 03:40:28 UTC) #1
aseemgarg
lgtm
4 years, 10 months ago (2016-02-22 21:54:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722473002/1
4 years, 10 months ago (2016-02-22 21:58:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11336)
4 years, 10 months ago (2016-02-22 21:59:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722473002/20001
4 years, 10 months ago (2016-02-23 05:43:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 06:18:44 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 06:19:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e805faa30ca258cc62fca07f3e1f73026eb0401
Cr-Commit-Position: refs/heads/master@{#34206}

Powered by Google App Engine
This is Rietveld 408576698