Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: ui/chromeos/network/network_icon.cc

Issue 1722453002: Extend vpnProvider to allow reconnections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/vpn_provider.idl ('k') | ui/chromeos/network/network_state_notifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/chromeos/network/network_icon.cc
diff --git a/ui/chromeos/network/network_icon.cc b/ui/chromeos/network/network_icon.cc
index b1785d6ef1dbb6a26d3446e57498e29a14188ae4..395bd620edc3b6865b5b0d0135e75f252c703fcc 100644
--- a/ui/chromeos/network/network_icon.cc
+++ b/ui/chromeos/network/network_icon.cc
@@ -741,7 +741,12 @@ base::string16 GetLabelForNetwork(const chromeos::NetworkState* network,
DCHECK(network);
std::string activation_state = network->activation_state();
if (icon_type == ICON_TYPE_LIST) {
- // Show "<network>: [Connecting|Activating]..."
+ // Show "<network>: [Connecting|Activating|Reconnecting]..."
+ if (network->IsReconnecting()) {
+ return l10n_util::GetStringFUTF16(
+ IDS_ASH_STATUS_TRAY_NETWORK_LIST_RECONNECTING,
+ base::UTF8ToUTF16(network->name()));
+ }
if (network->IsConnectingState()) {
return l10n_util::GetStringFUTF16(
IDS_ASH_STATUS_TRAY_NETWORK_LIST_CONNECTING,
@@ -760,7 +765,13 @@ base::string16 GetLabelForNetwork(const chromeos::NetworkState* network,
base::UTF8ToUTF16(network->name()));
}
} else {
- // Show "[Connected to|Connecting to|Activating] <network>" (non-list view).
+ // Show "[Connected to|Connecting to|Activating|Reconnecting to] <network>"
+ // (non-list view).
+ if (network->IsReconnecting()) {
+ return l10n_util::GetStringFUTF16(
+ IDS_ASH_STATUS_TRAY_NETWORK_RECONNECTING,
+ base::UTF8ToUTF16(network->name()));
+ }
if (network->IsConnectedState()) {
return l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_NETWORK_CONNECTED,
base::UTF8ToUTF16(network->name()));
@@ -827,10 +838,10 @@ void GetDefaultNetworkImageAndLabel(IconType icon_type,
const NetworkState* network;
// If we are connecting to a network, and there is either no connected
- // network, or the connection was user requested, use the connecting
- // network.
+ // network, or the connection was user requested, or shill triggered a
+ // reconnection, use the connecting network.
if (connecting_network &&
- (!connected_network ||
+ (!connected_network || connecting_network->IsReconnecting() ||
connect_handler->HasConnectingNetwork(connecting_network->path()))) {
network = connecting_network;
} else {
« no previous file with comments | « extensions/common/api/vpn_provider.idl ('k') | ui/chromeos/network/network_state_notifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698