Issue 172243005: Prevents crash when docking a detached panel while fullscreen window is active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172243005: Prevents crash when docking a detached panel while fullscreen window is active (Closed)

Created:
6 years, 10 months ago by varkha

Modified:
6 years, 10 months ago

Reviewers:
flackr

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Prevents crash when docking a detached panel while fullscreen window is active BUG=344909 TEST=Manual - follow steps in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252155

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	ash/wm/dock/docked_window_layout_manager.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

varkha

flackr@, could you please take a look? This prevents a crash when a docked window ...

6 years, 10 months ago (2014-02-19 17:28:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/172243005/30001

6 years, 10 months ago (2014-02-19 19:39:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/172243005/30001

6 years, 10 months ago (2014-02-20 00:18:36 UTC) #5

Message was sent while issue was closed.

Change committed as 252155