Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 172243003: Fix the output device selection introduced by 163343002 (Closed)

Created:
6 years, 10 months ago by no longer working on chromium
Modified:
6 years, 10 months ago
Reviewers:
Jói
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the output device selection introduced by 163343002. It corrects a mistake which does not assign the output device id to the member of the dispatcher. NOTRY=true BUG=344818 TEST=http://localhost:8080/hangout_services_test.html works with device selection. R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252025

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/audio/audio_manager_base.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
no longer working on chromium
Joi, could you please review this small fix? Thanks, SX
6 years, 10 months ago (2014-02-19 15:04:39 UTC) #1
Jói
LGTM On Wed, Feb 19, 2014 at 3:04 PM, <xians@chromium.org> wrote: > Reviewers: Jói, > ...
6 years, 10 months ago (2014-02-19 15:09:15 UTC) #2
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 10 months ago (2014-02-19 15:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/172243003/1
6 years, 10 months ago (2014-02-19 15:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/172243003/1
6 years, 10 months ago (2014-02-19 15:38:54 UTC) #5
no longer working on chromium
Committed patchset #2 manually as r252025 (tree was closed).
6 years, 10 months ago (2014-02-19 16:55:04 UTC) #6
no longer working on chromium
6 years, 10 months ago (2014-02-19 16:56:05 UTC) #7
Message was sent while issue was closed.
On 2014/02/19 16:55:04, xians1 wrote:
> Committed patchset #2 manually as r252025 (tree was closed).

Note that all the try jobs have been done in Patch Set 1, and no change in Patch
set 2.

Powered by Google App Engine
This is Rietveld 408576698