Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722373002: Add ability to save and load timelines from Observatory (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ability to save and load timelines from Observatory Fixes #25180 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b39b2c8cfbc0ffec78dd39274a8f45da23b84dc7

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/timeline_page.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.html View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/web/timeline.js View 1 2 chunks +85 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Cutch
4 years, 10 months ago (2016-02-23 20:29:15 UTC) #4
rmacnak
There is an issue for this: https://github.com/dart-lang/sdk/issues/25180 lgtm
4 years, 10 months ago (2016-02-23 23:58:04 UTC) #5
Cutch
4 years, 10 months ago (2016-02-24 17:11:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
b39b2c8cfbc0ffec78dd39274a8f45da23b84dc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698