Issue 172233003: Clean up weak objects in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172233003: Clean up weak objects in optimized code. (Closed)

Created:
6 years, 10 months ago by ulan

Modified:
6 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clean up weak objects in optimized code. This prepares for weak objects in IC stubs. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19489

Patch Set 2 : Address comments and fix whitespace #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -34 lines)			Patch
M	src/a64/lithium-codegen-a64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium-codegen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium-codegen.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/mark-compact.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/objects-visiting-inl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

Sven, could you please take a look. This CL just renames and moves functions.

6 years, 10 months ago (2014-02-19 10:57:57 UTC) #1

Sven Panne

LGTM with a nit https://codereview.chromium.org/172233003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/172233003/diff/1/src/objects.h#newcode5508 src/objects.h:5508: if (is_optimized_code()) return IsWeakObjectInOptimizedCode(object); return ...

6 years, 10 months ago (2014-02-19 12:38:40 UTC) #2

ulan

6 years, 10 months ago (2014-02-19 14:04:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19489 (presubmit successful).

Expand Messages | Collapse Messages

Issue 172233003: Clean up weak objects in optimized code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments and fix whitespace #

Messages