Index: chrome/browser/about_flags.cc |
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc |
index 192be1f264cd9115e9f4e717dfe13f088558b4df..85cd0e741abe6f6a0ee0b2f22a26e21c2b433cc1 100644 |
--- a/chrome/browser/about_flags.cc |
+++ b/chrome/browser/about_flags.cc |
@@ -56,6 +56,8 @@ |
#include "content/public/browser/user_metrics.h" |
#include "content/public/common/content_features.h" |
hbos_chromium
2016/02/25 15:20:16
(I noticed content/public/common/features.h is a l
jochen (gone - plz use gerrit)
2016/02/26 12:09:00
those are runtime enabled features
hbos_chromium
2016/02/26 14:13:34
*Meant to say content_features.h is a list of base
|
#include "content/public/common/content_switches.h" |
+#include "content/public/common/feature_h264_with_openh264_ffmpeg.h" |
+#include "content/public/common/features.h" |
#include "grit/components_strings.h" |
#include "media/base/media_switches.h" |
#include "media/midi/midi_switches.h" |
@@ -1801,13 +1803,20 @@ const FeatureEntry kFeatureEntries[] = { |
#if defined(ENABLE_EXTENSIONS) |
{"enable-tab-for-desktop-share", IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE, |
IDS_FLAG_ENABLE_TAB_FOR_DESKTOP_SHARE_DESCRIPTION, kOsAll, |
- SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)} |
+ SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)}, |
#endif |
#if defined(OS_ANDROID) |
{"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME, |
IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid, |
FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)}, |
#endif // defined(OS_ANDROID) |
+#if defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) |
+ {"enable-webrtc-h264-with-openh264-ffmpeg", |
+ IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_NAME, |
+ IDS_FLAGS_WEBRTC_H264_WITH_OPENH264_FFMPEG_DESCRIPTION, |
+ kOsMac | kOsWin | kOsLinux | kOsCrOS, |
+ FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)}, |
+#endif // defined(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) |
// NOTE: Adding new command-line switches requires adding corresponding |
// entries to enum "LoginCustomFlags" in histograms.xml. See note in |
jochen (gone - plz use gerrit)
2016/02/26 12:09:00
wow, such comment
so little attention payed
hbos_chromium
2016/02/26 14:13:34
Lol, thanks. Either missed it or thought it didn't
rkaplow
2016/03/01 19:17:28
Not entirely sure. I would guess 2/3 were omission
|
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. |