Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. | 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * This library is free software; you can redistribute it and/or | 4 * This library is free software; you can redistribute it and/or |
| 5 * modify it under the terms of the GNU Library General Public | 5 * modify it under the terms of the GNU Library General Public |
| 6 * License as published by the Free Software Foundation; either | 6 * License as published by the Free Software Foundation; either |
| 7 * version 2 of the License, or (at your option) any later version. | 7 * version 2 of the License, or (at your option) any later version. |
| 8 * | 8 * |
| 9 * This library is distributed in the hope that it will be useful, | 9 * This library is distributed in the hope that it will be useful, |
| 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
| 12 * Library General Public License for more details. | 12 * Library General Public License for more details. |
| 13 * | 13 * |
| 14 * You should have received a copy of the GNU Library General Public License | 14 * You should have received a copy of the GNU Library General Public License |
| 15 * along with this library; see the file COPYING.LIB. If not, write to | 15 * along with this library; see the file COPYING.LIB. If not, write to |
| 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, | 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, |
| 17 * Boston, MA 02110-1301, USA. | 17 * Boston, MA 02110-1301, USA. |
| 18 * | 18 * |
| 19 */ | 19 */ |
| 20 | 20 |
| 21 #include "config.h" | 21 #include "config.h" |
| 22 #include "core/html/forms/StepRange.h" | 22 #include "core/html/forms/StepRange.h" |
| 23 | 23 |
| 24 #include "HTMLNames.h" | 24 #include "HTMLNames.h" |
| 25 #include "core/html/parser/HTMLParserIdioms.h" | 25 #include "core/html/parser/HTMLParserIdioms.h" |
| 26 #include "wtf/MathExtras.h" | 26 #include "wtf/MathExtras.h" |
| 27 #include "wtf/text/WTFString.h" | 27 #include "wtf/text/WTFString.h" |
| 28 #include <float.h> | 28 #include <float.h> |
| 29 #include <stdio.h> | |
|
tkent
2014/02/28 01:12:04
This change is unnecessary.
Habib Virji
2014/03/04 09:33:44
Done. Apologies missed it.
| |
| 29 | 30 |
| 30 using namespace std; | 31 using namespace std; |
| 31 | 32 |
| 32 namespace WebCore { | 33 namespace WebCore { |
| 33 | 34 |
| 34 using namespace HTMLNames; | 35 using namespace HTMLNames; |
| 35 | 36 |
| 36 StepRange::StepRange() | 37 StepRange::StepRange() |
| 37 : m_maximum(100) | 38 : m_maximum(100) |
| 38 , m_minimum(0) | 39 , m_minimum(0) |
| (...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 150 return false; | 151 return false; |
| 151 const Decimal value = (valueForCheck - m_stepBase).abs(); | 152 const Decimal value = (valueForCheck - m_stepBase).abs(); |
| 152 if (!value.isFinite()) | 153 if (!value.isFinite()) |
| 153 return false; | 154 return false; |
| 154 // Decimal's fractional part size is DBL_MAN_DIG-bit. If the current value | 155 // Decimal's fractional part size is DBL_MAN_DIG-bit. If the current value |
| 155 // is greater than step*2^DBL_MANT_DIG, the following computation for | 156 // is greater than step*2^DBL_MANT_DIG, the following computation for |
| 156 // remainder makes no sense. | 157 // remainder makes no sense. |
| 157 DEFINE_STATIC_LOCAL(const Decimal, twoPowerOfDoubleMantissaBits, (Decimal::P ositive, 0, UINT64_C(1) << DBL_MANT_DIG)); | 158 DEFINE_STATIC_LOCAL(const Decimal, twoPowerOfDoubleMantissaBits, (Decimal::P ositive, 0, UINT64_C(1) << DBL_MANT_DIG)); |
| 158 if (value / twoPowerOfDoubleMantissaBits > m_step) | 159 if (value / twoPowerOfDoubleMantissaBits > m_step) |
| 159 return false; | 160 return false; |
| 160 // The computation follows HTML5 4.10.7.2.10 `The step attribute' : | 161 // http://www.whatwg.org/specs/web-apps/current-work/#the-step-attribute: |
|
tkent
2014/02/28 01:12:04
We don't need to update this now.
Habib Virji
2014/03/04 09:33:44
Done.
| |
| 161 // ... that number subtracted from the step base is not an integral multiple | 162 // ... that number subtracted from the step base is not an integral multiple |
| 162 // of the allowed value step, the element is suffering from a step mismatch. | 163 // of the allowed value step, the element is suffering from a step mismatch. |
| 163 const Decimal remainder = (value - m_step * (value / m_step).round()).abs(); | 164 const Decimal remainder = (value - m_step * (value / m_step).round()).abs(); |
| 164 // Accepts errors in lower fractional part which IEEE 754 single-precision | 165 // Accepts errors in lower fractional part which IEEE 754 double-precision |
|
tkent
2014/02/28 01:12:04
Ditto.
Habib Virji
2014/03/04 09:33:44
Done.
| |
| 165 // can't represent. | 166 // can't represent. |
| 166 const Decimal computedAcceptableError = acceptableError(); | 167 const Decimal computedAcceptableError = acceptableError(); |
| 167 return computedAcceptableError < remainder && remainder < (m_step - computed AcceptableError); | 168 return computedAcceptableError < remainder && remainder < (m_step - computed AcceptableError); |
| 168 } | 169 } |
| 169 | 170 |
| 170 } // namespace WebCore | 171 } // namespace WebCore |
| OLD | NEW |