Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1722193002: [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3783 matching lines...) Expand 10 before | Expand all | Expand 10 after
3794 VisitForAccumulatorValue(sub_expr); 3794 VisitForAccumulatorValue(sub_expr);
3795 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 3795 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
3796 3796
3797 if (expr->op() == Token::EQ_STRICT) { 3797 if (expr->op() == Token::EQ_STRICT) {
3798 Heap::RootListIndex nil_value = nil == kNullValue ? 3798 Heap::RootListIndex nil_value = nil == kNullValue ?
3799 Heap::kNullValueRootIndex : 3799 Heap::kNullValueRootIndex :
3800 Heap::kUndefinedValueRootIndex; 3800 Heap::kUndefinedValueRootIndex;
3801 __ CompareRoot(x0, nil_value); 3801 __ CompareRoot(x0, nil_value);
3802 Split(eq, if_true, if_false, fall_through); 3802 Split(eq, if_true, if_false, fall_through);
3803 } else { 3803 } else {
3804 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 3804 __ JumpIfSmi(x0, if_false);
3805 CallIC(ic, expr->CompareOperationFeedbackId()); 3805 __ Ldr(x0, FieldMemOperand(x0, HeapObject::kMapOffset));
3806 __ CompareRoot(x0, Heap::kTrueValueRootIndex); 3806 __ Ldrb(x1, FieldMemOperand(x0, Map::kBitFieldOffset));
3807 Split(eq, if_true, if_false, fall_through); 3807 __ TestAndSplit(x1, 1 << Map::kIsUndetectable, if_false, if_true,
3808 fall_through);
3808 } 3809 }
3809 3810
3810 context()->Plug(if_true, if_false); 3811 context()->Plug(if_true, if_false);
3811 } 3812 }
3812 3813
3813 3814
3814 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 3815 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
3815 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 3816 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
3816 context()->Plug(x0); 3817 context()->Plug(x0);
3817 } 3818 }
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
4263 } 4264 }
4264 4265
4265 return INTERRUPT; 4266 return INTERRUPT;
4266 } 4267 }
4267 4268
4268 4269
4269 } // namespace internal 4270 } // namespace internal
4270 } // namespace v8 4271 } // namespace v8
4271 4272
4272 #endif // V8_TARGET_ARCH_ARM64 4273 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698