Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1722193002: [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-types.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3981 matching lines...) Expand 10 before | Expand all | Expand 10 after
3992 VisitForAccumulatorValue(sub_expr); 3992 VisitForAccumulatorValue(sub_expr);
3993 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 3993 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
3994 if (expr->op() == Token::EQ_STRICT) { 3994 if (expr->op() == Token::EQ_STRICT) {
3995 Heap::RootListIndex nil_value = nil == kNullValue ? 3995 Heap::RootListIndex nil_value = nil == kNullValue ?
3996 Heap::kNullValueRootIndex : 3996 Heap::kNullValueRootIndex :
3997 Heap::kUndefinedValueRootIndex; 3997 Heap::kUndefinedValueRootIndex;
3998 __ LoadRoot(r1, nil_value); 3998 __ LoadRoot(r1, nil_value);
3999 __ cmp(r0, r1); 3999 __ cmp(r0, r1);
4000 Split(eq, if_true, if_false, fall_through); 4000 Split(eq, if_true, if_false, fall_through);
4001 } else { 4001 } else {
4002 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4002 __ JumpIfSmi(r0, if_false);
4003 CallIC(ic, expr->CompareOperationFeedbackId()); 4003 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset));
4004 __ CompareRoot(r0, Heap::kTrueValueRootIndex); 4004 __ ldrb(r1, FieldMemOperand(r0, Map::kBitFieldOffset));
4005 Split(eq, if_true, if_false, fall_through); 4005 __ tst(r1, Operand(1 << Map::kIsUndetectable));
4006 Split(ne, if_true, if_false, fall_through);
4006 } 4007 }
4007 context()->Plug(if_true, if_false); 4008 context()->Plug(if_true, if_false);
4008 } 4009 }
4009 4010
4010 4011
4011 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4012 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4012 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4013 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4013 context()->Plug(r0); 4014 context()->Plug(r0);
4014 } 4015 }
4015 4016
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
4266 DCHECK(interrupt_address == 4267 DCHECK(interrupt_address ==
4267 isolate->builtins()->OsrAfterStackCheck()->entry()); 4268 isolate->builtins()->OsrAfterStackCheck()->entry());
4268 return OSR_AFTER_STACK_CHECK; 4269 return OSR_AFTER_STACK_CHECK;
4269 } 4270 }
4270 4271
4271 4272
4272 } // namespace internal 4273 } // namespace internal
4273 } // namespace v8 4274 } // namespace v8
4274 4275
4275 #endif // V8_TARGET_ARCH_ARM 4276 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-types.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698