Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 1722193002: [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3867 matching lines...) Expand 10 before | Expand all | Expand 10 after
3878 VisitForAccumulatorValue(sub_expr); 3878 VisitForAccumulatorValue(sub_expr);
3879 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 3879 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
3880 3880
3881 if (expr->op() == Token::EQ_STRICT) { 3881 if (expr->op() == Token::EQ_STRICT) {
3882 Heap::RootListIndex nil_value = nil == kNullValue ? 3882 Heap::RootListIndex nil_value = nil == kNullValue ?
3883 Heap::kNullValueRootIndex : 3883 Heap::kNullValueRootIndex :
3884 Heap::kUndefinedValueRootIndex; 3884 Heap::kUndefinedValueRootIndex;
3885 __ CompareRoot(x0, nil_value); 3885 __ CompareRoot(x0, nil_value);
3886 Split(eq, if_true, if_false, fall_through); 3886 Split(eq, if_true, if_false, fall_through);
3887 } else { 3887 } else {
3888 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 3888 __ JumpIfSmi(x0, if_false);
3889 CallIC(ic, expr->CompareOperationFeedbackId()); 3889 __ Ldr(x0, FieldMemOperand(x0, HeapObject::kMapOffset));
3890 __ CompareRoot(x0, Heap::kTrueValueRootIndex); 3890 __ Ldrb(x1, FieldMemOperand(x0, Map::kBitFieldOffset));
3891 Split(eq, if_true, if_false, fall_through); 3891 __ TestAndSplit(x1, 1 << Map::kIsUndetectable, if_false, if_true,
3892 fall_through);
3892 } 3893 }
3893 3894
3894 context()->Plug(if_true, if_false); 3895 context()->Plug(if_true, if_false);
3895 } 3896 }
3896 3897
3897 3898
3898 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 3899 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
3899 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 3900 __ Ldr(x0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
3900 context()->Plug(x0); 3901 context()->Plug(x0);
3901 } 3902 }
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
4321 } 4322 }
4322 4323
4323 return INTERRUPT; 4324 return INTERRUPT;
4324 } 4325 }
4325 4326
4326 4327
4327 } // namespace internal 4328 } // namespace internal
4328 } // namespace v8 4329 } // namespace v8
4329 4330
4330 #endif // V8_TARGET_ARCH_ARM64 4331 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698