Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1722193002: [compiler] Drop the CompareNilIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 4044 matching lines...) Expand 10 before | Expand all | Expand 10 after
4055 VisitForAccumulatorValue(sub_expr); 4055 VisitForAccumulatorValue(sub_expr);
4056 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4056 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4057 if (expr->op() == Token::EQ_STRICT) { 4057 if (expr->op() == Token::EQ_STRICT) {
4058 Heap::RootListIndex nil_value = nil == kNullValue ? 4058 Heap::RootListIndex nil_value = nil == kNullValue ?
4059 Heap::kNullValueRootIndex : 4059 Heap::kNullValueRootIndex :
4060 Heap::kUndefinedValueRootIndex; 4060 Heap::kUndefinedValueRootIndex;
4061 __ LoadRoot(r1, nil_value); 4061 __ LoadRoot(r1, nil_value);
4062 __ cmp(r0, r1); 4062 __ cmp(r0, r1);
4063 Split(eq, if_true, if_false, fall_through); 4063 Split(eq, if_true, if_false, fall_through);
4064 } else { 4064 } else {
4065 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil); 4065 __ JumpIfSmi(r0, if_false);
4066 CallIC(ic, expr->CompareOperationFeedbackId()); 4066 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset));
4067 __ CompareRoot(r0, Heap::kTrueValueRootIndex); 4067 __ ldrb(r1, FieldMemOperand(r0, Map::kBitFieldOffset));
4068 Split(eq, if_true, if_false, fall_through); 4068 __ tst(r1, Operand(1 << Map::kIsUndetectable));
4069 Split(ne, if_true, if_false, fall_through);
4069 } 4070 }
4070 context()->Plug(if_true, if_false); 4071 context()->Plug(if_true, if_false);
4071 } 4072 }
4072 4073
4073 4074
4074 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4075 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4075 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4076 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
4076 context()->Plug(r0); 4077 context()->Plug(r0);
4077 } 4078 }
4078 4079
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
4329 DCHECK(interrupt_address == 4330 DCHECK(interrupt_address ==
4330 isolate->builtins()->OsrAfterStackCheck()->entry()); 4331 isolate->builtins()->OsrAfterStackCheck()->entry());
4331 return OSR_AFTER_STACK_CHECK; 4332 return OSR_AFTER_STACK_CHECK;
4332 } 4333 }
4333 4334
4334 4335
4335 } // namespace internal 4336 } // namespace internal
4336 } // namespace v8 4337 } // namespace v8
4337 4338
4338 #endif // V8_TARGET_ARCH_ARM 4339 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698