Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1722173003: Move SkPackBits to src/effects. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkPackBits to src/effects. Prior to this change SkPackBits.h was in include/core and SkPackBits.cpp in src/core. However, SkPackBits appears to have been written specifically as an implementation detail of the SkTableColorFilter effect. This change moves SkPackBits out of core and into effects, which is the only current user. Committed: https://skia.googlesource.com/skia/+/ccb74b824a16d0009f7f9ebcf2a03fb53451af9a

Patch Set 1 #

Patch Set 2 : Fix win64 warnings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -164 lines) Patch
M gyp/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
D include/core/SkPackBits.h View 1 chunk +0 lines, -46 lines 0 comments Download
D src/core/SkPackBits.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
A + src/effects/SkPackBits.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/effects/SkPackBits.cpp View 1 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722173003/1
4 years, 10 months ago (2016-02-23 16:25:32 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/6533)
4 years, 10 months ago (2016-02-23 16:27:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722173003/20001
4 years, 10 months ago (2016-02-23 18:44:00 UTC) #10
bungeman-skia
I have to have mtklein on this one, since he needs one a day.
4 years, 10 months ago (2016-02-23 19:01:40 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 19:03:51 UTC) #14
reed1
lgtm
4 years, 10 months ago (2016-02-23 20:50:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722173003/20001
4 years, 10 months ago (2016-02-23 20:54:47 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 20:55:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ccb74b824a16d0009f7f9ebcf2a03fb53451af9a

Powered by Google App Engine
This is Rietveld 408576698