perf/go/alerting/alerting.go - Issue 1722163002: Metrics2: Store a registry of Counters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf/go/alerting/alerting.go

Issue 1722163002: Metrics2: Store a registry of Counters (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: perf/go/alerting/alerting.go

diff --git a/perf/go/alerting/alerting.go b/perf/go/alerting/alerting.go

index e766e29eee678b09e43ac01c5dac51c4857b37f7..401ec62cb180f350b1410e1c070ddd9d32fb7da8 100644

--- a/perf/go/alerting/alerting.go

+++ b/perf/go/alerting/alerting.go

@@ -332,7 +332,7 @@ func calcNewClusters() {

// Start kicks off a go routine the periodically refreshes the current alerting clusters.

func Start(tb tracedb.MasterTileBuilder) {

newClustersGauge = metrics2.GetInt64Metric("perf.clustering.untriaged", nil)

- runsCounter = metrics2.NewCounter("perf.clustering.runs", nil)

+ runsCounter = metrics2.GetCounter("perf.clustering.runs", nil)

clusteringLatency = metrics2.NewTimer("perf.clustering.latency", nil)

tileBuilder = tb

client, err := auth.NewDefaultJWTServiceAccountClient("https://www.googleapis.com/auth/userinfo.email")

« no previous file with comments | « go/trace/service/impl.go ('k') | no next file » | no next file with comments »