Metrics2: Store a registry of Counters

Metrics2: Store a registry of Counters

This allows us to do GetCounter(...) and not have to keep the instance
around in calling code.

It's needed in go/util/http.go.

BUG=skia:4899
Committed: https://skia.googlesource.com/buildbot/+/faae1d4933530407c817579174ef05b7b21834f6

[borenet, 2016-02-23 13:20:26]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 13:20:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722163002/1

[borenet, 2016-02-23 13:20:49]

borenet@google.com changed reviewers:
+ kjlubick@google.com, stephana@google.com

[commit-bot: I haz the power, 2016-02-23 13:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 13:22:57]

Dry run: Try jobs failed on following builders:
  Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/b...)

[kjlubick, 2016-02-23 13:30:22]

lgtm

[borenet, 2016-02-23 17:55:14]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 17:56:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722163002/20001

[commit-bot: I haz the power, 2016-02-23 18:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:06:28]

Dry run: Try jobs failed on following builders:
  Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/b...)

[borenet, 2016-02-23 20:10:26]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 20:10:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722163002/40001

[commit-bot: I haz the power, 2016-02-23 20:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 20:29:44]

Dry run: Try jobs failed on following builders:
  Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/b...)

[borenet, 2016-02-24 12:29:33]

The CQ bit was checked by borenet@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 12:29:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722163002/60001

[commit-bot: I haz the power, 2016-02-24 12:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 12:32:42]

Dry run: This issue passed the CQ dry run.

[stephana, 2016-02-24 14:48:16]

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go
File go/metrics2/metrics.go (right):

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
go/metrics2/metrics.go:278: // getCounter creates or retrieves a Counter with
the given name and tag set and
This should be in counter.go file, all the other GetX(...) functions are the
packages where their main logic is.

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
go/metrics2/metrics.go:296: mtx: sync.Mutex{},
nit: Mutex doesn't need to be initialized, it's unlocked by default.

[borenet, 2016-02-24 15:09:35]

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go
File go/metrics2/metrics.go (right):

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
go/metrics2/metrics.go:278: // getCounter creates or retrieves a Counter with
the given name and tag set and
On 2016/02/24 14:48:16, stephana wrote:
> This should be in counter.go file, all the other GetX(...) functions are the
> packages where their main logic is. 

Done.

https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
go/metrics2/metrics.go:296: mtx: sync.Mutex{},
On 2016/02/24 14:48:16, stephana wrote:
> nit: Mutex doesn't need to be initialized, it's unlocked by default. 

Done, here and elsewhere.

[stephana, 2016-02-24 15:39:25]

On 2016/02/24 15:09:35, borenet wrote:
> https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go
> File go/metrics2/metrics.go (right):
> 
>
https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
> go/metrics2/metrics.go:278: // getCounter creates or retrieves a Counter with
> the given name and tag set and
> On 2016/02/24 14:48:16, stephana wrote:
> > This should be in counter.go file, all the other GetX(...) functions are the
> > packages where their main logic is. 
> 
> Done.
> 
>
https://codereview.chromium.org/1722163002/diff/60001/go/metrics2/metrics.go#...
> go/metrics2/metrics.go:296: mtx: sync.Mutex{},
> On 2016/02/24 14:48:16, stephana wrote:
> > nit: Mutex doesn't need to be initialized, it's unlocked by default. 
> 
> Done, here and elsewhere.

lgtm

[borenet, 2016-02-24 15:41:03]

The CQ bit was checked by borenet@google.com

[borenet, 2016-02-24 15:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from kjlubick@google.com
Link to the patchset: https://codereview.chromium.org/1722163002/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-24 15:41:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722163002/80001

[commit-bot: I haz the power, 2016-02-24 15:44:16]

Description was changed from

==========
Metrics2: Store a registry of Counters

This allows us to do GetCounter(...) and not have to keep the instance
around in calling code.

It's needed in go/util/http.go.

BUG=skia:4899
==========

to

==========
Metrics2: Store a registry of Counters

This allows us to do GetCounter(...) and not have to keep the instance
around in calling code.

It's needed in go/util/http.go.

BUG=skia:4899

Committed:
https://skia.googlesource.com/buildbot/+/faae1d4933530407c817579174ef05b7b218...
==========

[commit-bot: I haz the power, 2016-02-24 15:44:17]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/buildbot/+/faae1d4933530407c817579174ef05b7b218...