Add Uri.http and Uri.https constructors

Add Uri.http and Uri.https constructors

R=floitsch@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=24121

[floitsch, 2013-06-17 14:29:01]

LGTM.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode181
sdk/lib/core/uri.dart:181: * Create a new `http` URI with authority, path and
query.
Creates

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode192
sdk/lib/core/uri.dart:192: * argument. The path passed should not be encoded as
this
must not

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode193
sdk/lib/core/uri.dart:193: * constructor will encode the path.
encodes

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode195
sdk/lib/core/uri.dart:195: * The `query` component is set from the
[queryParameters] argument.
from the optional

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode196
sdk/lib/core/uri.dart:196: */
Maybe add some examples. In particular showing what is encoded by the
constructor and what isn't.

Examples:

    new Uri.https("google.com", "search", { "q": "dart" });
    new Uri.http("user:pass@host:8080", "");
    new Uri.http("host", "/a%2F")  // http://host/a%252F

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode204
sdk/lib/core/uri.dart:204: * Create a new `https` URI with authority, path and
query.
Creates

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode206
sdk/lib/core/uri.dart:206: * See [Uri.http] constructor for information on the
arguments.
This constructor is the same as [Uri.http] except for the scheme which is set to
`https`.

?

[floitsch, 2013-06-17 14:31:34]

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode196
sdk/lib/core/uri.dart:196: */
On 2013/06/17 14:29:01, floitsch wrote:
> Maybe add some examples. In particular showing what is encoded by the
> constructor and what isn't.
> 
> Examples:
> 
>     new Uri.https("google.com", "search", { "q": "dart" });
>     new Uri.http("user:pass@host:8080", "");
>     new Uri.http("host", "/a%2F")  // http://host/a%25252F

Also add example with space in path.

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.dart
File tests/corelib/uri_http_test.dart (right):

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.d...
tests/corelib/uri_http_test.dart:28: check(new Uri.http("host", "/a/b", { "c":
"d" }), "http://host/a/b?c=d");
add test that contains spaces (at least in the path).

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.d...
tests/corelib/uri_http_test.dart:29: check(new Uri.http("host", "/a/b", { "c=":
"&d" }), "http://host/a/b?c%3D=%26d");
long line.

[Søren Gjesse, 2013-06-18 06:05:34]

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart
File sdk/lib/core/uri.dart (right):

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode181
sdk/lib/core/uri.dart:181: * Create a new `http` URI with authority, path and
query.
On 2013/06/17 14:29:01, floitsch wrote:
> Creates

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode192
sdk/lib/core/uri.dart:192: * argument. The path passed should not be encoded as
this
On 2013/06/17 14:29:01, floitsch wrote:
> must not

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode193
sdk/lib/core/uri.dart:193: * constructor will encode the path.
On 2013/06/17 14:29:01, floitsch wrote:
> encodes

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode195
sdk/lib/core/uri.dart:195: * The `query` component is set from the
[queryParameters] argument.
On 2013/06/17 14:29:01, floitsch wrote:
> from the optional

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode196
sdk/lib/core/uri.dart:196: */
On 2013/06/17 14:29:01, floitsch wrote:
> Maybe add some examples. In particular showing what is encoded by the
> constructor and what isn't.
> 
> Examples:
> 
>     new Uri.https("google.com", "search", { "q": "dart" });
>     new Uri.http("user:pass@host:8080", "");
>     new Uri.http("host", "/a%2F")  // http://host/a%25252F

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode196
sdk/lib/core/uri.dart:196: */
On 2013/06/17 14:31:34, floitsch wrote:
> On 2013/06/17 14:29:01, floitsch wrote:
> > Maybe add some examples. In particular showing what is encoded by the
> > constructor and what isn't.
> > 
> > Examples:
> > 
> >     new Uri.https("google.com", "search", { "q": "dart" });
> >     new Uri.http("user:pass@host:8080", "");
> >     new Uri.http("host", "/a%2F")  // http://host/a%2525252F
> 
> Also add example with space in path.

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode204
sdk/lib/core/uri.dart:204: * Create a new `https` URI with authority, path and
query.
On 2013/06/17 14:29:01, floitsch wrote:
> Creates

Done.

https://codereview.chromium.org/17221003/diff/1/sdk/lib/core/uri.dart#newcode206
sdk/lib/core/uri.dart:206: * See [Uri.http] constructor for information on the
arguments.
On 2013/06/17 14:29:01, floitsch wrote:
> This constructor is the same as [Uri.http] except for the scheme which is set
to
> `https`.
> 
> ?

Done.

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.dart
File tests/corelib/uri_http_test.dart (right):

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.d...
tests/corelib/uri_http_test.dart:28: check(new Uri.http("host", "/a/b", { "c":
"d" }), "http://host/a/b?c=d");
On 2013/06/17 14:31:34, floitsch wrote:
> add test that contains spaces (at least in the path).

Done.

https://codereview.chromium.org/17221003/diff/1/tests/corelib/uri_http_test.d...
tests/corelib/uri_http_test.dart:29: check(new Uri.http("host", "/a/b", { "c=":
"&d" }), "http://host/a/b?c%3D=%26d");
On 2013/06/17 14:31:34, floitsch wrote:
> long line.

Done.

[Søren Gjesse, 2013-06-18 06:05:36]

Committed patchset #2 manually as r24121 (presubmit successful).