Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1721993002: Ship ES2015 Symbol.species (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES2015 Symbol.species This patch moves the ES2015 Symbol.species feature from staging to shipping. @@species should be good to ship now that the regression from fast-path cases in concat, slice and splice have been addressed. R=adamk BUG=v8:4093 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/1353b37d405e7f269330e1ad69d9d9970b1ba927 Cr-Commit-Position: refs/heads/master@{#34226}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/array-concat.js View 1 2 chunks +11 lines, -9 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721993002/1
4 years, 10 months ago (2016-02-23 01:29:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/12606)
4 years, 10 months ago (2016-02-23 01:45:23 UTC) #4
Dan Ehrenberg
Fixed tests, PTAL
4 years, 10 months ago (2016-02-23 18:39:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721993002/20001
4 years, 10 months ago (2016-02-23 18:39:34 UTC) #7
adamk
lgtm!
4 years, 10 months ago (2016-02-23 18:42:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721993002/20001
4 years, 10 months ago (2016-02-23 18:44:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 19:51:43 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:52:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1353b37d405e7f269330e1ad69d9d9970b1ba927
Cr-Commit-Position: refs/heads/master@{#34226}

Powered by Google App Engine
This is Rietveld 408576698