Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 172193002: Fix PathUtilsTest.TestGetNativeLibraryDirectory in components=shared_library build. (Closed)

Created:
6 years, 10 months ago by eugenis
Modified:
6 years, 10 months ago
Reviewers:
bulach, Philippe
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix PathUtilsTest.TestGetNativeLibraryDirectory in components=shared_library build. BUG=325685 R=bulach@chromium.org, pliard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/android/path_utils_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eugenis
6 years, 10 months ago (2014-02-19 10:40:46 UTC) #1
Philippe
lgtm, thanks!
6 years, 10 months ago (2014-02-19 12:45:33 UTC) #2
bulach
lgtm
6 years, 10 months ago (2014-02-19 12:54:01 UTC) #3
eugenis
The CQ bit was checked by eugenis@chromium.org
6 years, 10 months ago (2014-02-19 12:58:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/172193002/1
6 years, 10 months ago (2014-02-19 12:58:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/172193002/1
6 years, 10 months ago (2014-02-19 15:01:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@chromium.org/172193002/1
6 years, 10 months ago (2014-02-19 15:29:19 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 20:22:39 UTC) #8
Message was sent while issue was closed.
Change committed as 252061

Powered by Google App Engine
This is Rietveld 408576698