Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1721913002: Reland of Update V8 to version 5.0.60. (Closed)

Created:
4 years, 10 months ago by imcheng
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update V8 to version 5.0.60. (patchset #1 id:1 of https://codereview.chromium.org/1725523002/ ) Reason for revert: Win builder seemed to have recovered on its own on next build. Original issue's description: > Revert of Update V8 to version 5.0.60. (patchset #1 id:1 of https://codereview.chromium.org/1719203002/ ) > > Reason for revert: > Broke Win compile: > > FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper > environment.x86 > v8_snapshot_target_run_mksnapshot_3dd7b77762a753f6730b945160370894..rsp > ..\..\v8\tools\gyp > FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper > environment.x86 > v8_external_snapshot_target_run_mksnapshot__external__93bfc5871b63718af434b4cbb478e06a..rsp > ..\..\v8\tools\gyp > ninja: build stopped: subcommand failed. > > Original issue's description: > > Update V8 to version 5.0.60. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/a91392f8..f1990dd3 > > > > Please follow these instructions for assigning/CC'ing issues: > > https://github.com/v8/v8/wiki/Triaging%20issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > > > Committed: https://crrev.com/dd748df1ecdea0475ed018c0e5096651f4af0ed8 > > Cr-Commit-Position: refs/heads/master@{#376788} > > TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/b99fe46d578c03c48b58406628e27c4e0de7e0bf > Cr-Commit-Position: refs/heads/master@{#376802} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/508d3372ef07b3719f12faad1ba1db9cb55abf0a Cr-Commit-Position: refs/heads/master@{#376817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
imcheng
Created Reland of Update V8 to version 5.0.60.
4 years, 10 months ago (2016-02-22 21:37:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721913002/1
4 years, 10 months ago (2016-02-22 21:38:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 21:50:19 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:51:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/508d3372ef07b3719f12faad1ba1db9cb55abf0a
Cr-Commit-Position: refs/heads/master@{#376817}

Powered by Google App Engine
This is Rietveld 408576698