Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1721833005: Create new GM to target translations problems in GrAtlasTextContext (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 3

Patch Set 3 : feedback inc #

Patch Set 4 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
A gm/textblobblockreordering.cpp View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-23 21:13:16 UTC) #3
robertphillips
lgtm + a dox suggestion https://codereview.chromium.org/1721833005/diff/20001/gm/textblobblockreordering.cpp File gm/textblobblockreordering.cpp (right): https://codereview.chromium.org/1721833005/diff/20001/gm/textblobblockreordering.cpp#newcode1 gm/textblobblockreordering.cpp:1: /* 2016 ? https://codereview.chromium.org/1721833005/diff/20001/gm/textblobblockreordering.cpp#newcode9 ...
4 years, 10 months ago (2016-02-24 13:03:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721833005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721833005/60001
4 years, 10 months ago (2016-02-24 13:38:15 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:49:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cbbc9df143287e5fd85063822aa2c570ed8df9d5

Powered by Google App Engine
This is Rietveld 408576698