Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_unittest.cc

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_unittest.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_unittest.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3a1f42d3f8544cceb06a98c3e308ca4289330222
--- /dev/null
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_unittest.cc
@@ -0,0 +1,69 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
+
+#include <memory>
+
+#include "base/message_loop/message_loop.h"
+#include "chrome/browser/renderer_host/chrome_navigation_data.h"
+#include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h"
+#include "content/public/browser/navigation_data.h"
+#include "content/public/test/test_browser_thread.h"
+#include "net/base/request_priority.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_context.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+class ChromeResourceDispatcherHostDelegateTest : public testing::Test {
+ public:
+ ChromeResourceDispatcherHostDelegateTest()
+ : ui_thread_(content::BrowserThread::UI, &message_loop_) {}
+ ~ChromeResourceDispatcherHostDelegateTest() override {}
+
+ private:
+ base::MessageLoopForIO message_loop_;
+ content::TestBrowserThread ui_thread_;
+};
+
+TEST_F(ChromeResourceDispatcherHostDelegateTest,
+ GetNavigationDataWithDataReductionProxyData) {
+ std::unique_ptr<net::URLRequestContext> context(new net::URLRequestContext());
+ std::unique_ptr<net::URLRequest> fake_request(context->CreateRequest(
+ GURL("google.com"), net::RequestPriority::IDLE, nullptr));
+ // Add DataReductionProxyData to URLRequest
+ data_reduction_proxy::DataReductionProxyData* data_reduction_proxy_data =
+ data_reduction_proxy::DataReductionProxyData::GetDataAndCreateIfNecessary(
+ fake_request.get());
+ data_reduction_proxy_data->set_used_data_reduction_proxy(true);
+ std::unique_ptr<ChromeResourceDispatcherHostDelegate> delegate(
+ new ChromeResourceDispatcherHostDelegate());
+ ChromeNavigationData* chrome_navigation_data =
+ static_cast<ChromeNavigationData*>(
+ delegate->GetNavigationData(fake_request.get()));
+ data_reduction_proxy::DataReductionProxyData* data_reduction_proxy_data_copy =
+ chrome_navigation_data->GetDataReductionProxyData();
+ // The DataReductionProxyData should be a copy of the one on URLRequest
+ EXPECT_NE(data_reduction_proxy_data_copy, data_reduction_proxy_data);
+ // Make sure DataReductionProxyData was copied.
+ EXPECT_TRUE(data_reduction_proxy_data_copy->used_data_reduction_proxy());
+ EXPECT_EQ(
+ chrome_navigation_data,
+ ChromeNavigationData::GetDataAndCreateIfNecessary(fake_request.get()));
+}
+
+TEST_F(ChromeResourceDispatcherHostDelegateTest,
+ GetNavigationDataWithoutDataReductionProxyData) {
+ std::unique_ptr<net::URLRequestContext> context(new net::URLRequestContext());
+ std::unique_ptr<net::URLRequest> fake_request(context->CreateRequest(
+ GURL("google.com"), net::RequestPriority::IDLE, nullptr));
+ std::unique_ptr<ChromeResourceDispatcherHostDelegate> delegate(
+ new ChromeResourceDispatcherHostDelegate());
+ ChromeNavigationData* chrome_navigation_data =
+ static_cast<ChromeNavigationData*>(
+ delegate->GetNavigationData(fake_request.get()));
+ EXPECT_FALSE(chrome_navigation_data->GetDataReductionProxyData());
+}
« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698