Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..fb1885fcc93952917edcde7dd068117c128a7967
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
@@ -0,0 +1,59 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
+
+namespace content {
+class NavigationHandle;
+}
+
+namespace page_load_metrics {
+struct PageLoadExtraInfo;
+struct PageLoadTiming;
+}
+
+namespace data_reduction_proxy {
+
+namespace internal {
+
+// Various UMA histogram names for DataReductionProxy core page load metrics.
+extern const char kHistogramFirstContentfulPaintDataReductionProxy[];
+extern const char kHistogramFirstContentfulPaintDataReductionProxyLoFiOn[];
+
+} // namespace internal
+
+// Observer responsible for recording core page load metrics releveant to
+// DataReductionProxy.
+class DataReductionProxyMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ DataReductionProxyMetricsObserver();
+ ~DataReductionProxyMetricsObserver() override;
+
+ // page_load_metrics::PageLoadMetricsObserver:
+ void OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+
+ void RecordTimingHistograms(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) const;
+
+ private:
+ // True if the navigation requested LoFi.
+ bool lofi_requested_;
+
+ // True if the navigation was proxied through the data reduction proxy.
+ bool used_data_reduction_proxy_;
+
+ DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
+};
+
+} // namespace data_reduction_proxy
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698