Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created a DRP PageLoadMetricsObserver Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..65613aacc4a6b906ef851feaff77e45566c6eba3
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -0,0 +1,58 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"
tbansal1 2016/03/07 18:05:04 Linespace after this include.
RyanSturm 2016/03/08 19:47:42 Done.
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "components/page_load_metrics/common/page_load_timing.h"
+
+namespace {
+const char kDefaultTestUrl[] = "https://google.com";
+const char kDefaultTestUrl2[] = "https://whatever.com";
+} // namespace
+
+class DataReductionProxyMetricsObserverTest
+ : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ protected:
+ void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+ tracker->AddObserver(make_scoped_ptr(
tbansal1 2016/03/07 18:05:05 #include "base/memory/scoped_ptr.h"
RyanSturm 2016/03/08 19:47:42 Done.
+ new data_reduction_proxy::DataReductionProxyMetricsObserver()));
+ }
+};
+
+TEST_F(DataReductionProxyMetricsObserverTest, DataReductionProxyOff) {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
+ timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+ PopulateRequiredTimingFields(&timing);
+
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+ SimulateTimingUpdate(timing);
+
+ // Navigate again to force logging.
+ NavigateAndCommit(GURL(kDefaultTestUrl2));
+ histogram_tester().ExpectTotalCount(
+ data_reduction_proxy::internal::
+ kHistogramFirstContentfulPaintDataReductionProxy,
+ 0);
+}
+
+TEST_F(DataReductionProxyMetricsObserverTest, DataReductionProxyOn) {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
tbansal1 2016/03/07 18:05:05 #include "base/time/time.h"
RyanSturm 2016/03/08 19:47:42 Done.
+ timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+ PopulateRequiredTimingFields(&timing);
+
+ SetSimulateUsedDataReductionProxy(true);
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+ SimulateTimingUpdate(timing);
+ SetSimulateUsedDataReductionProxy(false);
+
+ // Navigate again to force logging.
+ NavigateAndCommit(GURL(kDefaultTestUrl2));
+ histogram_tester().ExpectTotalCount(
+ data_reduction_proxy::internal::
+ kHistogramFirstContentfulPaintDataReductionProxy,
+ 1);
+}

Powered by Google App Engine
This is Rietveld 408576698