Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/browser/loader/navigation_resource_throttle.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NavigationData final draft before adding tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_resource_throttle.h
diff --git a/content/browser/loader/navigation_resource_throttle.h b/content/browser/loader/navigation_resource_throttle.h
index 6357b20aad4016e9c14d684c989ace9f04c1a09d..57fc66c78777ecd28d70b9ada0ae0b69b924193d 100644
--- a/content/browser/loader/navigation_resource_throttle.h
+++ b/content/browser/loader/navigation_resource_throttle.h
@@ -8,38 +8,41 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "content/public/browser/navigation_throttle.h"
#include "content/public/browser/resource_throttle.h"
namespace net {
class URLRequest;
}
namespace content {
+class ResourceDispatcherHostImpl;
// This ResourceThrottle is used to convey throttling information to the UI
// thread during navigations. The UI thread can then use its NavigationThrottle
// mechanism to interact with the navigation.
class NavigationResourceThrottle : public ResourceThrottle {
public:
- NavigationResourceThrottle(net::URLRequest* request);
+ NavigationResourceThrottle(net::URLRequest* request,
+ ResourceDispatcherHostImpl* rdh);
nasko 2016/04/26 20:18:40 Use full names for parameters, it isn't that much
RyanSturm 2016/04/27 23:27:47 Done.
~NavigationResourceThrottle() override;
// ResourceThrottle overrides:
void WillStartRequest(bool* defer) override;
void WillRedirectRequest(const net::RedirectInfo& redirect_info,
bool* defer) override;
void WillProcessResponse(bool* defer) override;
const char* GetNameForLogging() const override;
private:
void OnUIChecksPerformed(NavigationThrottle::ThrottleCheckResult result);
net::URLRequest* request_;
+ ResourceDispatcherHostImpl* rdh_;
nasko 2016/04/26 20:18:40 Same here, having a longer name makes it a bit eas
RyanSturm 2016/04/27 23:27:47 Done.
base::WeakPtrFactory<NavigationResourceThrottle> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(NavigationResourceThrottle);
};
} // namespace content
#endif // CONTENT_BROWSER_LOADER_NAVIGATION_RESOURCE_THROTTLE_H_

Powered by Google App Engine
This is Rietveld 408576698