content/child/weburlresponse_extradata_impl.h - Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint

Side by Side Diff: content/child/weburlresponse_extradata_impl.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/loader/resource_loader.cc ('K') | « content/child/web_url_loader_impl.cc ('k') | content/common/frame_messages.h » ('j') | content/public/browser/resource_dispatcher_host_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_	5 #ifndef CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_

6 #define CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_	6 #define CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 }	83 }

84	84

85 bool is_ftp_directory_listing() const { return is_ftp_directory_listing_; }	85 bool is_ftp_directory_listing() const { return is_ftp_directory_listing_; }

86 void set_is_ftp_directory_listing(bool is_ftp_directory_listing) {	86 void set_is_ftp_directory_listing(bool is_ftp_directory_listing) {

87 is_ftp_directory_listing_ = is_ftp_directory_listing;	87 is_ftp_directory_listing_ = is_ftp_directory_listing;

88 }	88 }

89	89

90 bool is_using_lofi() const { return is_using_lofi_; }	90 bool is_using_lofi() const { return is_using_lofi_; }

91 void set_is_using_lofi(bool is_using_lofi) { is_using_lofi_ = is_using_lofi; }	91 void set_is_using_lofi(bool is_using_lofi) { is_using_lofi_ = is_using_lofi; }

92	92

	93 bool used_data_reduction_proxy() const { return used_data_reduction_proxy_; }

	94 void set_used_data_reduction_proxy(bool used_data_reduction_proxy) {

	95 used_data_reduction_proxy_ = used_data_reduction_proxy;

	96 }

	97

93 private:	98 private:

94 std::string npn_negotiated_protocol_;	99 std::string npn_negotiated_protocol_;

95 bool is_ftp_directory_listing_;	100 bool is_ftp_directory_listing_;

96 bool was_fetched_via_proxy_;	101 bool was_fetched_via_proxy_;

97 net::HostPortPair proxy_server_;	102 net::HostPortPair proxy_server_;

98 bool was_fetched_via_spdy_;	103 bool was_fetched_via_spdy_;

99 bool was_npn_negotiated_;	104 bool was_npn_negotiated_;

100 net::HttpResponseInfo::ConnectionInfo connection_info_;	105 net::HttpResponseInfo::ConnectionInfo connection_info_;

101 bool was_alternate_protocol_available_;	106 bool was_alternate_protocol_available_;

102 bool is_using_lofi_;	107 bool is_using_lofi_;

	108 bool used_data_reduction_proxy_;
	tbansal1 2016/03/10 22:49:47 Is this (and the functions above) used somewhere? Is this (and the functions above) used somewhere? RyanSturm 2016/03/14 21:00:46 It's used in web_url_loader_impl.cc and render_fra Show quoted text On 2016/03/10 22:49:47, tbansal1 wrote: > Is this (and the functions above) used somewhere? It's used in web_url_loader_impl.cc and render_frame_impl.cc; here is the plumbing path to NavigationHandleImpl: https://codereview.chromium.org/1721813002/diff/80001/content/browser/loader/... ResourceResponse.head (ResourceResponseInfo) https://codereview.chromium.org/1721813002/diff/80001/content/child/web_url_l... ResourceResponseInfo -> WebURLResponseExtraDataImpl https://codereview.chromium.org/1721813002/diff/80001/content/renderer/render... WebURLResponseExtraDataImpl -> FrameHostMsg_DidCommitProvisionalLoad_Params https://codereview.chromium.org/1721813002/diff/80001/content/browser/frame_h... FrameHostMsg_DidCommitProvisionalLoad_Params -> NavigationHandleImpl
103	109

104 DISALLOW_COPY_AND_ASSIGN(WebURLResponseExtraDataImpl);	110 DISALLOW_COPY_AND_ASSIGN(WebURLResponseExtraDataImpl);

105 };	111 };

106	112

107 } // namespace content	113 } // namespace content

108	114

109 #endif // CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_	115 #endif // CONTENT_CHILD_WEBURLRESPONSE_EXTRADATA_IMPL_H_

OLD	NEW