Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
7
8 #include "base/macros.h"
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
10
11 namespace content {
12 class NavigationHandle;
13 }
14
15 namespace page_load_metrics {
16 struct PageLoadExtraInfo;
17 struct PageLoadTiming;
18 }
19
20 namespace data_reduction_proxy {
21
22 namespace internal {
23 extern const char kHistogramFirstContentfulPaintDataReductionProxy[];
24 extern const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn[];
25 extern const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff[];
26 }
27
28 class DataReductionProxyMetricsObserver
29 : public page_load_metrics::PageLoadMetricsObserver {
30 public:
31 DataReductionProxyMetricsObserver();
32 ~DataReductionProxyMetricsObserver() override;
33
34 // page_load_metrics::PageLoadMetricsObserver implementation:
35 void OnCommit(content::NavigationHandle* navigation_handle) override;
36 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
37 const page_load_metrics::PageLoadExtraInfo& info) override;
38
39 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
40 const page_load_metrics::PageLoadExtraInfo& info);
tbansal1 2016/03/08 22:14:43 can this be a const method?
RyanSturm 2016/03/10 00:37:58 Done.
41
42 private:
43 // True if the navigation used LoFi.
44 bool is_using_lofi_;
45
46 // True if the navigation was proxied through the data reduction proxy.
47 bool used_data_reduction_proxy_;
48 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
49 };
50
51 } // namespace data_reduction_proxy
52
53 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698