Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/renderer_host/chrome_navigation_data_unittest.cc

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: making NavigationData const after clone Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/renderer_host/chrome_navigation_data.h"
6
7 #include <memory>
8
9 #include "base/memory/ptr_util.h"
10 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data .h"
11 #include "content/public/browser/navigation_data.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 class ChromeNavigationDataTest : public testing::Test {
15 public:
16 ChromeNavigationDataTest() {}
17 ~ChromeNavigationDataTest() override {}
18 };
19
20 TEST_F(ChromeNavigationDataTest, AddingDataReductionProxyData) {
21 std::unique_ptr<ChromeNavigationData> data(new ChromeNavigationData());
22 data_reduction_proxy::DataReductionProxyData* data_reduction_proxy_data =
23 new data_reduction_proxy::DataReductionProxyData();
24 data->SetDataReductionProxyData(base::WrapUnique(data_reduction_proxy_data));
25 EXPECT_EQ(data_reduction_proxy_data, data->GetDataReductionProxyData());
26 }
27
28 TEST_F(ChromeNavigationDataTest, Clone) {
29 std::unique_ptr<ChromeNavigationData> data(new ChromeNavigationData());
30 data_reduction_proxy::DataReductionProxyData* data_reduction_proxy_data =
31 new data_reduction_proxy::DataReductionProxyData();
32 data->SetDataReductionProxyData(base::WrapUnique(data_reduction_proxy_data));
33 std::unique_ptr<content::NavigationData> clone_data = data->Clone();
34 ChromeNavigationData* clone_chrome_data =
35 static_cast<ChromeNavigationData*>(clone_data.get());
36 EXPECT_NE(data.get(), clone_data.get());
37 EXPECT_NE(data.get(), clone_chrome_data);
38 EXPECT_NE(data->GetDataReductionProxyData(),
39 clone_chrome_data->GetDataReductionProxyData());
40 EXPECT_EQ(data_reduction_proxy_data, data->GetDataReductionProxyData());
41 EXPECT_FALSE(!clone_chrome_data->GetDataReductionProxyData());
nasko 2016/05/09 17:35:43 Why not EXPECT_TRUE?
RyanSturm 2016/05/09 18:27:31 Done.
42 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698