Adding DRP specfic UMA for FirstContentfulPaint

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
+
+namespace content {
+class NavigationHandle;
+}
+
+namespace page_load_metrics {
+struct PageLoadExtraInfo;
+struct PageLoadTiming;
+}
+
+namespace data_reduction_proxy {
+
+namespace internal {
+// Various UMA histogram names for DataReductionProxy core page load metrics

[bengr, 2016/04/29 21:14:20]

nit: Add a period.

[RyanSturm, 2016/05/02 19:52:19]

Done.

+extern const char kHistogramFirstContentfulPaintDataReductionProxy[];
+extern const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn[];
+extern const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff[];
+}
+
+// Observer responsible for recording core page load metrics releveant to
+// DataReductionProxy.
+class DataReductionProxyMetricsObserver
+    : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+  DataReductionProxyMetricsObserver();
+  ~DataReductionProxyMetricsObserver() override;
+
+  // page_load_metrics::PageLoadMetricsObserver implementation:
+  void OnCommit(content::NavigationHandle* navigation_handle) override;
+  void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+                  const page_load_metrics::PageLoadExtraInfo& info) override;
+  void RecordTimingHistograms(

[bengr, 2016/04/29 21:14:20]

Add a blank line above.

[RyanSturm, 2016/05/02 19:52:19]

Done.

+      const page_load_metrics::PageLoadTiming& timing,
+      const page_load_metrics::PageLoadExtraInfo& info) const;
+
+ private:
+  // True if the navigation used LoFi.
+  bool is_using_lofi_;

[bengr, 2016/04/29 21:14:20]

Rename as used_lofi. Also, is this only if a lofi transformation was performed?
It shouldn't be true if LoFi is requested but the server does not transform.

[RyanSturm, 2016/05/02 19:52:19]

Right. I'll refactor to reflect that LoFi was requested for this navigation. The
current UMA appears to make the same decision.

+
+  // True if the navigation was proxied through the data reduction proxy.
+  bool used_data_reduction_proxy_;
+
+  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
+};
+
+}  // namespace data_reduction_proxy
+
+#endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_