Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Side by Side Diff: chrome/browser/renderer_host/chrome_navigation_data.cc

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NavigationData final draft before adding tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/renderer_host/chrome_navigation_data.h"
6
7 #include "base/memory/ptr_util.h"
8 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data .h"
9
10 ChromeNavigationData::ChromeNavigationData() {}
11
12 ChromeNavigationData::~ChromeNavigationData() {}
13
14 std::unique_ptr<content::NavigationData> ChromeNavigationData::Clone() const {
15 ChromeNavigationData* copy = new ChromeNavigationData();
nasko 2016/04/26 20:18:39 Why keep a raw pointer? Just use the unique_ptr.
RyanSturm 2016/04/27 23:27:46 Done.
16 if (data_reduction_proxy_data_)
17 copy->SetDataReductionProxyData(data_reduction_proxy_data_->DeepCopy());
18 return base::WrapUnique(copy);
nasko 2016/04/26 20:18:39 You should WrapUnique the return value of the allo
RyanSturm 2016/04/27 23:27:46 Done.
19 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698