Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NavigationData final draft before adding tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metric s_observer.h"
6
7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/renderer_host/chrome_navigation_data.h"
9 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data .h"
10 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h"
11 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
12 #include "components/page_load_metrics/browser/page_load_metrics_util.h"
13 #include "components/page_load_metrics/common/page_load_timing.h"
14 #include "content/public/browser/navigation_data.h"
15 #include "content/public/browser/navigation_handle.h"
16
17 namespace data_reduction_proxy {
18
19 namespace internal {
20
21 const char kHistogramFirstContentfulPaintDataReductionProxy[] =
22 "PageLoad.Clients.DataReductionProxy.Timing2."
23 "NavigationToFirstContentfulPaint";
24 const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn[] =
25 "PageLoad.Clients.DataReductionProxy.AutoLoFiOn.Timing2."
26 "NavigationToFirstContentfulPaint";
27 const char kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff[] =
28 "PageLoad.Clients.DataReductionProxy.AutoLoFiOff.Timing2."
29 "NavigationToFirstContentfulPaint";
30
31 } // namespace internal
32
33 DataReductionProxyMetricsObserver::DataReductionProxyMetricsObserver()
34 : is_using_lofi_(false), used_data_reduction_proxy_(false) {}
35
36 DataReductionProxyMetricsObserver::~DataReductionProxyMetricsObserver() {}
37
38 // Check if the NavigationData indicates anything about the DataReductionProxy.
39 void DataReductionProxyMetricsObserver::OnCommit(
40 content::NavigationHandle* navigation_handle) {
41 // As documented in content, this NavigationData is a clone of the
42 // NavigationData instance returned from
43 // ResourceDispatcherHostDelegate::GetNavigationData during commit, which is
44 // always a ChromeNavigationData.
45 ChromeNavigationData* chrome_navigation_data =
46 static_cast<ChromeNavigationData*>(
47 navigation_handle->GetNavigationData());
48 if (!chrome_navigation_data)
49 return;
50 data_reduction_proxy::DataReductionProxyData* data =
51 chrome_navigation_data->GetDataReductionProxyData();
52 if (data) {
53 used_data_reduction_proxy_ = data->get_used_data_reduction_proxy();
54 is_using_lofi_ = data->get_is_using_lofi();
55 }
56 }
57
58 void DataReductionProxyMetricsObserver::OnComplete(
59 const page_load_metrics::PageLoadTiming& timing,
60 const page_load_metrics::PageLoadExtraInfo& info) {
61 RecordTimingHistograms(timing, info);
62 }
63
64 // Recording UMA for FirstContentfulPaint for various DataReductionProxy
65 // configurations.
66 void DataReductionProxyMetricsObserver::RecordTimingHistograms(
67 const page_load_metrics::PageLoadTiming& timing,
68 const page_load_metrics::PageLoadExtraInfo& info) const {
69 if (timing.first_contentful_paint.is_zero() || !used_data_reduction_proxy_)
70 return;
71 PAGE_LOAD_HISTOGRAM(
72 internal::kHistogramFirstContentfulPaintDataReductionProxy,
73 timing.first_contentful_paint);
74 if (is_using_lofi_) {
75 if (data_reduction_proxy::params::IsIncludedInLoFiEnabledFieldTrial()) {
76 PAGE_LOAD_HISTOGRAM(
77 internal::kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn,
78 timing.first_contentful_paint);
79 } else if (data_reduction_proxy::params::
80 IsIncludedInLoFiControlFieldTrial()) {
81 PAGE_LOAD_HISTOGRAM(
82 internal::kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff,
83 timing.first_contentful_paint);
84 }
85 }
86 }
87
88 } // namespace data_reduction_proxy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698