Issue 17218: Fix for a crasher in SSLManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17218: Fix for a crasher in SSLManager (Closed)

Created:
11 years, 11 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

In some cases (related to window.open() with no contents, see bug for more details) we may get notified of SSL error or mixed-contents without a NavigationEntry. This CL ensures we don't crash in that case. BUG=3845 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7644

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/browser/ssl_manager.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

It is the simple fix for bug 3845 that we discussed before the holidays.

11 years, 11 months ago (2009-01-06 23:44:15 UTC) #1

abarth-chromium

11 years, 11 months ago (2009-01-06 23:50:05 UTC) #2

Yeah, I remember we talked about this and decided this was the right fix.  LGTM.

Expand Messages | Collapse Messages