Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1721763003: Silence dpkg-query errors in install-build-deps. (Closed)

Created:
4 years, 10 months ago by Torne
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Silence dpkg-query errors in install-build-deps. On leading-edge Ubuntu versions there are no LTS backport packages, and dpkg-query prints an error about nothing matching the wildcard to stderr, which has caused at least one user to think the script didn't install mesa correctly. The script handles this case just fine, though (it expands to an empty array and sets mesa_variant to emptystring, whcih is correct), so just redirect stderr to avoid this spurious error message. BUG= Committed: https://crrev.com/12cd9f6cf09631a18f11f123cc02e753dfcaa199 Cr-Commit-Position: refs/heads/master@{#377332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
4 years, 10 months ago (2016-02-23 10:51:06 UTC) #2
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-23 21:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721763003/1
4 years, 10 months ago (2016-02-24 18:10:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 18:52:31 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:54:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12cd9f6cf09631a18f11f123cc02e753dfcaa199
Cr-Commit-Position: refs/heads/master@{#377332}

Powered by Google App Engine
This is Rietveld 408576698