Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1721743002: Revert of fix misc asserts and checks found by fuzzer (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1719913002/ ) Reason for revert: Looks to be causing failures in LayerTreeHostFilters* tests (https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/177297/steps/cc_unittests%20%28with%20patch%29/logs/stdio). Original issue's description: > fix misc asserts and checks found by fuzzer > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/653db51b440491b0fb1908bf5a43dcc89c90044d TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/23e7af0e8ab8377b28e1399b4950def672284724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -79 lines) Patch
M include/core/SkPathEffect.h View 2 chunks +2 lines, -14 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 2 chunks +5 lines, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 3 chunks +4 lines, -3 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +32 lines, -36 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ethannicholas
Created Revert of fix misc asserts and checks found by fuzzer
4 years, 10 months ago (2016-02-22 15:42:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721743002/1
4 years, 10 months ago (2016-02-22 15:42:07 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 15:42:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23e7af0e8ab8377b28e1399b4950def672284724

Powered by Google App Engine
This is Rietveld 408576698