tools/metrics/histograms/histograms.xml - Issue 1721633002: Added UMA collection for fullscreen / mouse lock bubble re-shows.

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1721633002: Added UMA collection for fullscreen / mouse lock bubble re-shows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move name to constant. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/ui/exclusive_access/exclusive_access_controller_base.cc ('K') | « chrome/browser/ui/exclusive_access/mouse_lock_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ccf3c6ca1b2de1dd6d963123defe6ea2410e2622..36342ffc954bd7b5d0de5dc741fbb4cef78a7675 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -11531,6 +11531,28 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="ExclusiveAccess.BubbleReshowsPerSession.Fullscreen">

+ <owner>mgiuca@chromium.org</owner>

+ <summary>

+ The number of times the fullscreen bubble was re-shown due to inactivity in

+ a session of fullscreen mode (not including mouse lock). If the mouse is

scheib 2016/02/23 23:52:26 I don't think " (not including mouse lock)" is nee

Ilya Sherman 2016/02/24 01:08:20 Optional nit: I'd write "during a session" rather

Matt Giuca 2016/02/24 03:00:31 I put that because "fullscreen" internally refers

Matt Giuca 2016/02/24 03:00:31 Done.

+ also locked while a re-show occurs, counts for both this and

scheib 2016/02/23 23:52:26 When the mouse is also locked during a re-show bot

Matt Giuca 2016/02/24 03:00:31 Done.

+ BubbleReshowsPerSession.MouseLock. Includes all types of fullscreen

+ (user-triggered, extension-triggered and page-triggered). Only recorded when

+ the simplified-fullscreen-ui flag is enabled.

+ </summary>

+</histogram>

+<histogram name="ExclusiveAccess.BubbleReshowsPerSession.MouseLock">

+ <owner>mgiuca@chromium.org</owner>

+ <summary>

+ The number of times the mouse lock bubble was re-shown due to inactivity in

+ a session of mouse lock mode. If also in fullscreen while a re-show occurs,

scheib 2016/02/23 23:52:26 ditto

Matt Giuca 2016/02/24 03:00:31 Done.

+ counts for both this and BubbleReshowsPerSession.Fullscreen. Only recorded

+ when the simplified-fullscreen-ui flag is enabled.

+ </summary>

+</histogram>

Deprecated with M46.