Chromium Code Reviews| Index: chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h |
| diff --git a/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h b/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h |
| index 11e8e0d19d1fb207945f30716dfe012c7d315c9b..8156eeffeee6d219b5165ae2d8749682f7e68286 100644 |
| --- a/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h |
| +++ b/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h |
| @@ -65,6 +65,12 @@ class ExclusiveAccessControllerBase : public content::NotificationObserver { |
| const content::NotificationSource& source, |
| const content::NotificationDetails& details) override; |
| + // For recording UMA. |
| + // Called when the bubble UI is reshown after a timeout. |
| + void BubbleReshown(); |
|
scheib
2016/02/23 23:52:26
Rename RecordBubbleReshownUMA. Remove first commen
Matt Giuca
2016/02/24 03:00:31
Done.
|
| + // For recording UMA. Called when the exclusive access session ends. |
| + void Exiting(); |
|
scheib
2016/02/23 23:52:26
RecordExitingUMA
Matt Giuca
2016/02/24 03:00:31
Done.
|
| + |
| protected: |
| void SetTabWithExclusiveAccess(content::WebContents* tab); |
| @@ -77,6 +83,9 @@ class ExclusiveAccessControllerBase : public content::NotificationObserver { |
| // if necessary. |
| virtual void NotifyTabExclusiveAccessLost() = 0; |
| + // Suffix used in the name of histograms relating to this type of controller. |
| + virtual const char* HistogramSuffix() = 0; |
| + |
| private: |
| void UpdateNotificationRegistrations(); |
| @@ -84,7 +93,10 @@ class ExclusiveAccessControllerBase : public content::NotificationObserver { |
| content::NotificationRegistrar registrar_; |
| - content::WebContents* tab_with_exclusive_access_; |
| + content::WebContents* tab_with_exclusive_access_ = nullptr; |
| + |
| + // The number of bubble re-shows for the current session (reset upon exiting). |
| + int bubble_reshow_count_ = 0; |
| DISALLOW_COPY_AND_ASSIGN(ExclusiveAccessControllerBase); |
| }; |