Continue recording object allocation after navigation

Source/devtools/front_end/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 962 matching lines @@
 
     /**
      * @override
      * @return {boolean}
      */
     buttonClicked: function()
     {
         return this._toggleRecording();
     },
 
-    _startRecordingProfile: function()
+    /**
+     * @param {boolean=} continueAfterNavigation
+     */
+    _startRecordingProfile: function(continueAfterNavigation)

[loislo, 2014/02/19 13:06:19]

could you please extract the common part into a separate method _initProfileData
and use it from _reset method.

[yurys, 2014/02/19 13:34:37]

Done.

     {
         if (this.profileBeingRecorded())
             return;
         this._profileBeingRecorded = new WebInspector.HeapProfileHeader(this);
         this._lastSeenIndex = -1;
         this._profileSamples = {
             'sizes': [],
             'ids': [],
             'timestamps': [],
             'max': [],
             'totalTime': 30000
         };
         this._profileBeingRecorded._profileSamples = this._profileSamples;
         this._recording = true;
         this.addProfile(this._profileBeingRecorded);
         this._profileBeingRecorded.updateStatus(WebInspector.UIString("Recording\u2026"));
-        HeapProfilerAgent.startTrackingHeapObjects(WebInspector.experimentsSettings.allocationProfiler.isEnabled());
+        if (!continueAfterNavigation)
+            HeapProfilerAgent.startTrackingHeapObjects(WebInspector.experimentsSettings.allocationProfiler.isEnabled());
         this.dispatchEventToListeners(WebInspector.TrackingHeapSnapshotProfileType.TrackingStarted);
     },
 
     _stopRecordingProfile: function()
     {
         this._profileBeingRecorded.updateStatus(WebInspector.UIString("Snapshotting\u2026"));
         /**
          * @param {?string} error
          * @this {WebInspector.HeapSnapshotProfileType}
          */
@@ skipping 27 matching lines @@
         return WebInspector.UIString("HEAP TIMELINES");
     },
 
     get description()
     {
         return WebInspector.UIString("Record JavaScript object allocations over time. Use this profile type to isolate memory leaks.");
     },
 
     _reset: function()
     {
+        var wasRecording = this._recording;
+        // Clear current profile to avoid stoppting backend.

[loislo, 2014/02/19 13:06:19]

stoppting?

[yurys, 2014/02/19 13:34:37]

Done.

[yurys, 2014/02/19 13:34:37]

Done.

+        this._profileBeingRecorded = null;
         WebInspector.HeapSnapshotProfileType.prototype._reset.call(this);
-        if (this._recording)
-            this._stopRecordingProfile();
         this._profileSamples = null;
         this._lastSeenIndex = -1;
+        if (wasRecording)
+            this._startRecordingProfile(true);
     },
 
     /**
      * @override
      */
     profileBeingRecordedRemoved: function()
     {
         this._stopRecordingProfile();
         this._profileSamples = null;
     },
@@ skipping 67 matching lines @@
 
     _prepareToLoad: function()
     {
         console.assert(!this._receiver, "Already loading");
         this._setupWorker();
         this.updateStatus(WebInspector.UIString("Loading\u2026"), true);
     },
 
     _finishLoad: function()
     {
-        this._receiver.close(function() {});
+        if (!this._wasDisposed)
+            this._receiver.close(function() {});
         if (this._bufferedWriter) {
             this._bufferedWriter.close(this._didWriteToTempFile.bind(this));
             this._bufferedWriter = null;
         }
     },
 
     _didWriteToTempFile: function(tempFile)
     {
+        if (this._wasDisposed) {
+            if (tempFile)
+                tempFile.remove();
+            return;
+        }
         this._tempFile = tempFile;
         if (!tempFile)
             this._failedToCreateTempFile = true;
         if (this._onTempFileReady) {
             this._onTempFileReady();
             this._onTempFileReady = null;
         }
     },
 
     _setupWorker: function()
@@ skipping 583 matching lines @@
     },
 
     /**
      * @return {number}
      */
     boundarySpan: function()
     {
         return this._maximumBoundaries - this._minimumBoundaries;
     }
 }