Issue 172163005: Continue recording object allocation after navigation

Issue 172163005: Continue recording object allocation after navigation (Closed)

Created:
6 years, 10 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Continue recording object allocation after navigation Old profile is removed on HeapProfiler.resetProfiles message and a new one is added immediately to collect all object allocation events from the backend after navigation. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168565

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -9 lines)			Patch
M	Source/core/inspector/InspectorHeapProfilerAgent.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorHeapProfilerAgent.cpp	View	1	5 chunks	+19 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotView.js	View	1 2 3	5 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

loislo

lgtm with nits https://codereview.chromium.org/172163005/diff/190001/Source/devtools/front_end/HeapSnapshotView.js File Source/devtools/front_end/HeapSnapshotView.js (right): https://codereview.chromium.org/172163005/diff/190001/Source/devtools/front_end/HeapSnapshotView.js#newcode986 Source/devtools/front_end/HeapSnapshotView.js:986: _startRecordingProfile: function(continueAfterNavigation) could you please extract ...

6 years, 10 months ago (2014-02-19 13:06:18 UTC) #3

yurys

https://codereview.chromium.org/172163005/diff/190001/Source/devtools/front_end/HeapSnapshotView.js File Source/devtools/front_end/HeapSnapshotView.js (right): https://codereview.chromium.org/172163005/diff/190001/Source/devtools/front_end/HeapSnapshotView.js#newcode986 Source/devtools/front_end/HeapSnapshotView.js:986: _startRecordingProfile: function(continueAfterNavigation) On 2014/02/19 13:06:19, loislo wrote: > > ...

6 years, 10 months ago (2014-02-19 13:34:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/172163005/250001

6 years, 9 months ago (2014-03-05 14:46:57 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/172163005/250001

6 years, 9 months ago (2014-03-05 20:58:55 UTC) #7

Message was sent while issue was closed.

Change committed as 168565

Expand Messages | Collapse Messages