Issue 17214005: Rename RenderText member variables to better reflect what they do.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17214005: Rename RenderText member variables to better reflect what they do. (Closed)

Created:
7 years, 6 months ago by ojan

Modified:
7 years, 6 months ago

Reviewers:
cbiesinger, esprehn, eae

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename RenderText member variables to better reflect what they do. Removed a couple comments that were slightly incorrect and didn't add much value since you had to read the code anyways to really understand what was going on. Also, fix some style violations to make check-webkit-style happy. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152665

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -74 lines)			Patch
M	Source/core/rendering/RenderBlock.cpp	View	3 chunks	+19 lines, -22 lines	0 comments	Download
M	Source/core/rendering/RenderText.h	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderText.cpp	View	10 chunks	+45 lines, -43 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/17214005/1

7 years, 6 months ago (2013-06-18 19:03:08 UTC) #3

cbiesinger

Thanks for doing this before adding the additional variable!

7 years, 6 months ago (2013-06-18 19:10:15 UTC) #4

Message was sent while issue was closed.

Change committed as 152665

Expand Messages | Collapse Messages