Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html

Issue 1721373002: UTF-8 detector for pages missing encoding info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/fast/encoding/char-decoding-invalid-trail.html ('K') | « third_party/WebKit/LayoutTests/fast/encoding/char-decoding-invalid-trail-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil-a1.css » ('j') | third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil-a1.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html
diff --git a/third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html b/third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html
index 33c9671df51dc4ed595a264b0eae3eb688bc0689..367e4f2bb49c572ae6186d213cf3b37461eac3a8 100644
--- a/third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html
+++ b/third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil.html
@@ -23,35 +23,40 @@ span.fail { background: red; color: white; }
<link rel=stylesheet href="css-charset-evil-c2.css">
<link rel=stylesheet href="css-charset-evil-c3.css">
<link rel=stylesheet href="css-charset-evil-d1.css">
+<!--
+ Note that encoding utf-8 is not suitable for this test since the encoding
+ is always detected regardless of an error (or lack thereof) in the directive
+ @charset. See crbug.com/583549.
+-->
<pre>
Correct:
-@charset "utf-8"; <span id="a1&#195;&#164;" class='fail'>FAIL</span><span id="a1&#228;" class='pass'>PASS</span>
+@charset "iso-8859-7"; <span id="a1&#225;&#226;" class='fail'>FAIL</span><span id="a1&#945&#946;" class='pass'>PASS</span>
Wrong Capitalization:
-@CHARSET "utf-8"; <span id="a2&#195;&#164;" class='pass'>PASS</span><span id="a2&#228;" class='fail'>FAIL</span>
-@ChArSeT "utf-8"; <span id="a3&#195;&#164;" class='pass'>PASS</span><span id="a3&#228;" class='fail'>FAIL</span>
-@cHaRsEt "utf-8"; <span id="a4&#195;&#164;" class='pass'>PASS</span><span id="a4&#228;" class='fail'>FAIL</span>
+@CHARSET "iso-8859-7"; <span id="a2&#225;&#226;" class='pass'>PASS</span><span id="a2&#945;&#946;" class='fail'>FAIL</span>
+@ChArSeT "iso-8859-7"; <span id="a3&#225;&#226;" class='pass'>PASS</span><span id="a3&#945;&#946;" class='fail'>FAIL</span>
+@cHaRsEt "iso-8859-7"; <span id="a4&#225;&#226;" class='pass'>PASS</span><span id="a4&#945;&#946;" class='fail'>FAIL</span>
Wrong Whitespace:
-@charset"utf-8"; <span id="b1&#195;&#164;" class='pass'>PASS</span><span id="b1&#228;" class='fail'>FAIL</span>
-@charset "utf-8"; <span id="b2&#195;&#164;" class='pass'>PASS</span><span id="b2&#228;" class='fail'>FAIL</span>
-@charset\9"utf-8"; <span id="b3&#195;&#164;" class='pass'>PASS</span><span id="b3&#228;" class='fail'>FAIL</span>
-@charset\A"utf-8"; <span id="b4&#195;&#164;" class='pass'>PASS</span><span id="b4&#228;" class='fail'>FAIL</span>
-@charset\C"utf-8"; <span id="b5&#195;&#164;" class='pass'>PASS</span><span id="b5&#228;" class='fail'>FAIL</span>
-@charset\D"utf-8"; <span id="b6&#195;&#164;" class='pass'>PASS</span><span id="b6&#228;" class='fail'>FAIL</span>
-@charset "utf-8" ; <span id="b7&#195;&#164;" class='pass'>PASS</span><span id="b7&#228;" class='fail'>FAIL</span>
- @charset "utf-8"; <span id="b8&#195;&#164;" class='pass'>PASS</span><span id="b8&#228;" class='fail'>FAIL</span>
+@charset"iso-8859-7"; <span id="b1&#225;&#226;" class='pass'>PASS</span><span id="b1&#945;&#946;" class='fail'>FAIL</span>
+@charset "iso-8859-7"; <span id="b2&#225;&#226;" class='pass'>PASS</span><span id="b2&#945;&#946;" class='fail'>FAIL</span>
+@charset\9"iso-8859-7"; <span id="b3&#225;&#226;" class='pass'>PASS</span><span id="b3&#945;&#946;" class='fail'>FAIL</span>
+@charset\A"iso-8859-7"; <span id="b4&#225;&#226;" class='pass'>PASS</span><span id="b4&#945;&#946;" class='fail'>FAIL</span>
+@charset\C"iso-8859-7"; <span id="b5&#225;&#226;" class='pass'>PASS</span><span id="b5&#945;&#946;" class='fail'>FAIL</span>
+@charset\D"iso-8859-7"; <span id="b6&#225;&#226;" class='pass'>PASS</span><span id="b6&#945;&#946;" class='fail'>FAIL</span>
+@charset "iso-8859-7" ; <span id="b7&#225;&#226;" class='pass'>PASS</span><span id="b7&#945;&#946;" class='fail'>FAIL</span>
+ @charset "iso-8859-7"; <span id="b8&#225;&#226;" class='pass'>PASS</span><span id="b8&#945;&#946;" class='fail'>FAIL</span>
Wrong Quote character:
-@charset 'utf-8'; <span id="c1&#195;&#164;" class='pass'>PASS</span><span id="c1&#228;" class='fail'>FAIL</span>
-@charset "utf-8'; <span id="c2&#195;&#164;" class='pass'>PASS</span><span id="c2&#228;" class='fail'>FAIL</span>
-@charset 'utf-8"; <span id="c3&#195;&#164;" class='pass'>PASS</span><span id="c3&#228;" class='fail'>FAIL</span>
+@charset 'iso-8859-7'; <span id="c1&#225;&#226;" class='pass'>PASS</span><span id="c1&#945;&#946;" class='fail'>FAIL</span>
+@charset "iso-8859-7'; <span id="c2&#225;&#226;" class='pass'>PASS</span><span id="c2&#945;&#946;" class='fail'>FAIL</span>
+@charset 'iso-8859-7"; <span id="c3&#225;&#226;" class='pass'>PASS</span><span id="c3&#945;&#946;" class='fail'>FAIL</span>
Wrong Semicolon:
-@charset "utf-8" <span id="d1&#195;&#164;" class='pass'>PASS</span><span id="d1&#228;" class='fail'>FAIL</span>
+@charset "iso-8859-7" <span id="d1&#225;&#226;" class='pass'>PASS</span><span id="d1&#945;&#946;" class='fail'>FAIL</span>
</pre>
<script>
if (window.testRunner)
testRunner.dumpAsText();
-</script>
+</script>
« third_party/WebKit/LayoutTests/fast/encoding/char-decoding-invalid-trail.html ('K') | « third_party/WebKit/LayoutTests/fast/encoding/char-decoding-invalid-trail-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil-a1.css » ('j') | third_party/WebKit/LayoutTests/fast/encoding/css-charset-evil/css-charset-evil-a1.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698