third_party/WebKit/Source/core/dom/Node.h - Issue 1721333002: Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 1721333002: Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Hook in allocateOnHeapIndex Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSValue.h ('K') | « third_party/WebKit/Source/core/css/CSSValue.h ('k') | third_party/WebKit/Source/platform/heap/Heap.h » ('j') | third_party/WebKit/Source/platform/heap/Heap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.h

diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h

index fd8a9391402c48a11a13615cb316c254d135f19d..1e010180f1f141aa45db6a154a9b6061685db729 100644

--- a/third_party/WebKit/Source/core/dom/Node.h

+++ b/third_party/WebKit/Source/core/dom/Node.h

@@ -184,7 +184,8 @@ public:

static void* allocateObject(size_t size, bool isEager)

{

ThreadState* state = ThreadStateFor<ThreadingTrait<Node>::Affinity>::state();

- return Heap::allocateOnHeapIndex(state, size, isEager ? BlinkGC::EagerSweepHeapIndex : BlinkGC::NodeHeapIndex, GCInfoTrait<EventTarget>::index());

+ const char* typeName = WTF_HEAP_PROFILER_TYPE_NAME(Node);

Primiano Tucci (use gerrit) 2016/02/29 17:23:14 ditto here

hajimehoshi 2016/03/03 10:12:31 Done.

+ return Heap::allocateOnHeapIndex(state, size, isEager ? BlinkGC::EagerSweepHeapIndex : BlinkGC::NodeHeapIndex, GCInfoTrait<EventTarget>::index(), typeName);

}

#else // !ENABLE(OILPAN)

// All Nodes are placed in their own heap partition for security.