Bug fix: Add BlinkGC allocation hooks to CSS, Node and vector/table backing

third_party/WebKit/Source/platform/heap/HeapAllocator.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef HeapAllocator_h
 #define HeapAllocator_h
 
 #include "platform/heap/Heap.h"
 #include "platform/heap/TraceTraits.h"
 #include "wtf/Allocator.h"
@@ skipping 44 matching lines @@
         return reinterpret_cast<T*>(heap->allocateObject(Heap::allocationSizeFromSize(size), gcInfoIndex));
     }
     static void freeVectorBacking(void*);
     static bool expandVectorBacking(void*, size_t);
     static bool shrinkVectorBacking(void* address, size_t quantizedCurrentSize, size_t quantizedShrunkSize);
     template <typename T>
     static T* allocateInlineVectorBacking(size_t size)
     {
         size_t gcInfoIndex = GCInfoTrait<HeapVectorBacking<T, VectorTraits<T>>>::index();
         ThreadState* state = ThreadStateFor<ThreadingTrait<T>::Affinity>::state();
-        return reinterpret_cast<T*>(Heap::allocateOnHeapIndex(state, size, BlinkGC::InlineVectorHeapIndex, gcInfoIndex));
+        Address address = Heap::allocateOnHeapIndex(state, size, BlinkGC::InlineVectorHeapIndex, gcInfoIndex);
+        const char* typeName = WTF_HEAP_PROFILER_TYPE_NAME(T);
+        HeapAllocHooks::allocationHookIfEnabled(address, size, typeName);

[sof, 2016/02/23 09:13:02]

Can you guarantee that this doesn't add a single extra cycle to the object
allocation path in official builds?

[hajimehoshi, 2016/02/23 09:27:17]

Yes. The actual hooks doesn't allocate any objects from BlinkGC.
https://codereview.chromium.org/1701813003/diff/40001/third_party/WebKit/Sour...

[Primiano Tucci (use gerrit), 2016/02/25 06:55:51]

Is there any way we can make this future proof such that if somebody adds a new
call to allocateOnHeapIndex somehwere else we don't forget to add a call to the
hook?
Maybe move the hook inside Heap::allocateOnHeapIndex and pass the type as const
char*?

[hajimehoshi, 2016/02/25 07:06:01]

Good point. Such hooks should be in allocateOnHeapIndex. I found the missing
hooks just by searching allocateOnHeapIndex.

BTW, as I said at the issue, the hooks added by this CL might cause performance
regression. I suggested using a build macro, but if we move these hooks in
allocateOnHeapIndex, can't we see the Oilpan heap profiler without the build
macro?

[hajimehoshi, 2016/02/26 09:37:13]

Done.

+        return reinterpret_cast<T*>(address);
     }
     static void freeInlineVectorBacking(void*);
     static bool expandInlineVectorBacking(void*, size_t);
     static bool shrinkInlineVectorBacking(void* address, size_t quantizedCurrentSize, size_t quantizedShrunkSize);
 
     template <typename T, typename HashTable>
     static T* allocateHashTableBacking(size_t size)
     {
         size_t gcInfoIndex = GCInfoTrait<HeapHashTableBacking<HashTable>>::index();
         ThreadState* state = ThreadStateFor<ThreadingTrait<T>::Affinity>::state();
-        return reinterpret_cast<T*>(Heap::allocateOnHeapIndex(state, size, BlinkGC::HashTableHeapIndex, gcInfoIndex));
+        Address address = Heap::allocateOnHeapIndex(state, size, BlinkGC::HashTableHeapIndex, gcInfoIndex);
+        const char* typeName = WTF_HEAP_PROFILER_TYPE_NAME(T);
+        HeapAllocHooks::allocationHookIfEnabled(address, size, typeName);
+        return reinterpret_cast<T*>(address);
     }
     template <typename T, typename HashTable>
     static T* allocateZeroedHashTableBacking(size_t size)
     {
         return allocateHashTableBacking<T, HashTable>(size);
     }
     static void freeHashTableBacking(void* address);
     static bool expandHashTableBacking(void*, size_t);
 
     template <typename Return, typename Metadata>
@@ skipping 468 matching lines @@
     static_assert(sizeof(T), "T must be fully defined");
     // All heap allocated node pointers need visiting to keep the nodes alive,
     // regardless of whether they contain pointers to other heap allocated
     // objects.
     static const bool value = true;
 };
 
 } // namespace WTF
 
 #endif