Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: gin/public/isolate_holder.h

Issue 172133002: gin: Make it possible to use gin array buffers when running on top of blink (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/per_isolate_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index d68e4d5a58b72e28c0930fafe5cb0e6ae5c2c3ac..67c23358c87a051c9a7d0eb3e81c0e6cbbb6cbd0 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -8,10 +8,7 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "gin/gin_export.h"
-
-namespace v8 {
-class Isolate;
-}
+#include "v8/include/v8.h"
namespace gin {
@@ -30,6 +27,9 @@ class PerIsolateData;
class GIN_EXPORT IsolateHolder {
public:
IsolateHolder();
+ IsolateHolder(v8::Isolate* isolate, v8::ArrayBuffer::Allocator* allocator);
+
+ // TODO(jochen): Remove.
explicit IsolateHolder(v8::Isolate* isolate);
~IsolateHolder();
@@ -37,7 +37,7 @@ class GIN_EXPORT IsolateHolder {
v8::Isolate* isolate() { return isolate_; }
private:
- void Init();
+ void Init(v8::ArrayBuffer::Allocator* allocator);
bool isolate_owner_;
v8::Isolate* isolate_;
« no previous file with comments | « gin/per_isolate_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698