Implements secure sockets on Mac OS with SecureTransport API

Implements secure sockets on Mac OS with SecureTransport API

R=iposva@google.com

Committed: https://github.com/dart-lang/sdk/commit/e900b1b94417a4fe46467f80ee6fec118a779c5d

[zra, 2016-02-23 05:59:50]

Description was changed from

==========
pkcs12 data work


Builtin certs work


Maybe this will compile?

BUG=
==========

to

==========
Mac SSL Work
==========

[zra, 2016-03-04 18:09:00]

Description was changed from

==========
Mac SSL Work
==========

to

==========
Implements secure sockets on Mac OS with SecureTransport API
==========

[zra, 2016-03-04 18:10:49]

zra@google.com changed reviewers:
+ iposva@google.com

[zra, 2016-03-04 18:10:51]

This is ready for review. I can also split this into 4-ish smaller CLs for
easier reviewing, but tests will fail in the intermediate states.

[zra, 2016-03-04 23:36:44]

On 2016/03/04 18:10:51, zra wrote:
> This is ready for review. I can also split this into 4-ish smaller CLs for
> easier reviewing, but tests will fail in the intermediate states.

This is what the first CL would look like:
https://codereview.chromium.org/1764403002/. After that I'd add support for
making a connection using only the builtin trusted certs and proceed from there.

[zra, 2016-03-21 20:13:34]

Ivan, I made another pass over the code. The remaining questions I had were
whether it would be an improvement to move SSLCertContext from the source file
to the header file, and whether the new names for the files are okay, i.e.
_boringssl.{h,cc} and _macos.{h,cc}.

[Ivan Posva, 2016-03-21 20:38:01]

LGTM with small nits.

-Ivan

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/io_impl_so...
File runtime/bin/io_impl_sources.gypi (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/io_impl_so...
runtime/bin/io_impl_sources.gypi:80: 'sources!': [
The '!' is hard to see. Please add a comment that this is excluding the
root_certificates.cc file.

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
File runtime/bin/secure_socket.h (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
runtime/bin/secure_socket.h:13: // Declare the OS-specific types ahead of
defining the generic class.
There seems to be no "generic class" being defined below. Please adjust the
comment.

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
File runtime/bin/secure_socket_boringssl.h (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
runtime/bin/secure_socket_boringssl.h:8: #if !defined(BIN_SECURE_SOCKET_H_)
How about using the usual way of avoiding code instead of the large amounts of
'sources!' in the case of these different configurations?

P.S. Different CL is fine for this.

[zra, 2016-03-21 22:32:59]

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/io_impl_so...
File runtime/bin/io_impl_sources.gypi (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/io_impl_so...
runtime/bin/io_impl_sources.gypi:80: 'sources!': [
On 2016/03/21 20:38:01, Ivan Posva wrote:
> The '!' is hard to see. Please add a comment that this is excluding the
> root_certificates.cc file.

Done.

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
File runtime/bin/secure_socket.h (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
runtime/bin/secure_socket.h:13: // Declare the OS-specific types ahead of
defining the generic class.
On 2016/03/21 20:38:01, Ivan Posva wrote:
> There seems to be no "generic class" being defined below. Please adjust the
> comment.

Removed comment

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
File runtime/bin/secure_socket_boringssl.h (right):

https://codereview.chromium.org/1721283002/diff/240001/runtime/bin/secure_soc...
runtime/bin/secure_socket_boringssl.h:8: #if !defined(BIN_SECURE_SOCKET_H_)
On 2016/03/21 20:38:01, Ivan Posva wrote:
> How about using the usual way of avoiding code instead of the large amounts of
> 'sources!' in the case of these different configurations?
> 
> P.S. Different CL is fine for this.

This will be easier to do after the Android CL here lands:
https://codereview.chromium.org/1811583003/ because the root_certificates.cc
file lives in a separate github repo, and I'd like to update it only once.
Unfortunately that CL will make things temporarily more complicated, which I'll
fix right after.

[zra, 2016-03-21 22:46:33]

Description was changed from

==========
Implements secure sockets on Mac OS with SecureTransport API
==========

to

==========
Implements secure sockets on Mac OS with SecureTransport API

R=iposva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e900b1b94417a4fe46467f80ee6fec118a779c5d
==========

[zra, 2016-03-21 22:46:35]

Committed patchset #14 (id:260001) manually as
e900b1b94417a4fe46467f80ee6fec118a779c5d (presubmit successful).