content/renderer/media/user_media_client_impl.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/user_media_client_impl.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed o1ka's 2nd round of comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_track.cc ('K') | « content/renderer/media/track_audio_renderer.cc ('k') | content/renderer/media/user_media_client_impl_unittest.cc » ('j') | content/renderer/media/webrtc_local_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/user_media_client_impl.cc

diff --git a/content/renderer/media/user_media_client_impl.cc b/content/renderer/media/user_media_client_impl.cc

index 16d1427bb0cc4c4eaf4337c695d05350d8076bb3..56b52133baff607def1f565ce8b85ef15f8b498e 100644

--- a/content/renderer/media/user_media_client_impl.cc

+++ b/content/renderer/media/user_media_client_impl.cc

@@ -1054,7 +1054,7 @@ void UserMediaClientImpl::UserMediaRequestInfo::StartAudioTrack(

const blink::WebMediaConstraints& constraints) {

DCHECK(track.source().type() == blink::WebMediaStreamSource::TypeAudio);

MediaStreamAudioSource* native_source =

- static_cast <MediaStreamAudioSource*>(track.source().extraData());

+ MediaStreamAudioSource::From(track.source());

DCHECK(native_source);

sources_.push_back(track.source());