content/renderer/media/speech_recognition_audio_sink.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/speech_recognition_audio_sink.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed o1ka's 2nd round of comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_track.cc ('K') | « content/renderer/media/rtc_peer_connection_handler_unittest.cc ('k') | content/renderer/media/speech_recognition_audio_sink_unittest.cc » ('j') | content/renderer/media/webrtc_local_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/speech_recognition_audio_sink.cc

diff --git a/content/renderer/media/speech_recognition_audio_sink.cc b/content/renderer/media/speech_recognition_audio_sink.cc

index 1035aff13da4a11c1182c72e60c6067ee4fd6cc4..3beb5a8d6b226e8db989167bb020c25d03efc746 100644

--- a/content/renderer/media/speech_recognition_audio_sink.cc

+++ b/content/renderer/media/speech_recognition_audio_sink.cc

@@ -61,11 +61,8 @@ SpeechRecognitionAudioSink::~SpeechRecognitionAudioSink() {

// static

bool SpeechRecognitionAudioSink::IsSupportedTrack(

const blink::WebMediaStreamTrack& track) {

- if (track.source().type() != blink::WebMediaStreamSource::TypeAudio)

- return false;

MediaStreamAudioSource* native_source =

- static_cast<MediaStreamAudioSource*>(track.source().extraData());

+ MediaStreamAudioSource::From(track.source());

if (!native_source)

return false;