Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/public/renderer/media_stream_audio_sink.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed o1ka's 2nd round of comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/media_stream_audio_sink.cc
diff --git a/content/public/renderer/media_stream_audio_sink.cc b/content/public/renderer/media_stream_audio_sink.cc
index a6e01a9c7cf47800d30843dcfee8d2e8a0bef984..ad5e12111d72c9e4724aa3d0de2cb8974e2fc90b 100644
--- a/content/public/renderer/media_stream_audio_sink.cc
+++ b/content/public/renderer/media_stream_audio_sink.cc
@@ -15,21 +15,27 @@ void MediaStreamAudioSink::AddToAudioTrack(
MediaStreamAudioSink* sink,
const blink::WebMediaStreamTrack& track) {
DCHECK(track.source().type() == blink::WebMediaStreamSource::TypeAudio);
- MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::GetTrack(track);
- native_track->AddSink(sink);
+ if (MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::From(track))
+ native_track->AddSink(sink);
+ else
+ NOTREACHED();
}
void MediaStreamAudioSink::RemoveFromAudioTrack(
MediaStreamAudioSink* sink,
const blink::WebMediaStreamTrack& track) {
- MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::GetTrack(track);
- native_track->RemoveSink(sink);
+ if (MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::From(track))
+ native_track->RemoveSink(sink);
+ else
+ NOTREACHED();
}
media::AudioParameters MediaStreamAudioSink::GetFormatFromAudioTrack(
const blink::WebMediaStreamTrack& track) {
- MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::GetTrack(track);
- return native_track->GetOutputFormat();
+ if (MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::From(track))
+ return native_track->GetOutputFormat();
+ NOTREACHED();
+ return media::AudioParameters();
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698