content/renderer/media/rtc_peer_connection_handler.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed o1ka's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_track.h ('K') | « content/renderer/media/mock_media_stream_registry.cc ('k') | content/renderer/media/rtc_peer_connection_handler_unittest.cc » ('j') | content/renderer/media/webrtc/media_stream_remote_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_peer_connection_handler.cc

diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc

index 9b694e8c8c4c9eaeb89e48468c93b8838f67b39f..3b741aa3dfe964cc2fd4571388e3339ff85379a3 100644

--- a/content/renderer/media/rtc_peer_connection_handler.cc

+++ b/content/renderer/media/rtc_peer_connection_handler.cc

@@ -1364,7 +1364,7 @@ blink::WebRTCDTMFSenderHandler* RTCPeerConnectionHandler::createDTMFSender(

TRACE_EVENT0("webrtc", "RTCPeerConnectionHandler::createDTMFSender");

DVLOG(1) << "createDTMFSender.";

- MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::GetTrack(track);

+ MediaStreamAudioTrack* native_track = MediaStreamAudioTrack::From(track);

if (!native_track || !native_track->is_local_track() ||

track.source().type() != blink::WebMediaStreamSource::TypeAudio) {

DLOG(ERROR) << "The DTMF sender requires a local audio track.";