content/renderer/media/media_stream_center.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_center.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed o1ka's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_track.h ('K') | « content/renderer/media/media_stream_audio_track.cc ('k') | content/renderer/media/media_stream_renderer_factory_impl.cc » ('j') | content/renderer/media/webrtc/media_stream_remote_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_center.cc

diff --git a/content/renderer/media/media_stream_center.cc b/content/renderer/media/media_stream_center.cc

index ad7f8ddf6f1c2281a6f693fab87fab0b419e3cd0..afc2201bd8fa223c504d3ad0fb22e61b2545e689 100644

--- a/content/renderer/media/media_stream_center.cc

+++ b/content/renderer/media/media_stream_center.cc

@@ -15,6 +15,7 @@

#include "content/public/renderer/media_stream_audio_sink.h"

#include "content/public/renderer/render_thread.h"

#include "content/renderer/media/media_stream.h"

+#include "content/renderer/media/media_stream_audio_track.h"

#include "content/renderer/media/media_stream_source.h"

#include "content/renderer/media/media_stream_video_source.h"

#include "content/renderer/media/media_stream_video_track.h"

@@ -40,7 +41,7 @@ namespace {

void CreateNativeAudioMediaStreamTrack(

const blink::WebMediaStreamTrack& track,

PeerConnectionDependencyFactory* factory) {

- DCHECK(!track.extraData());

+ DCHECK(!MediaStreamAudioTrack::From(track));

blink::WebMediaStreamSource source = track.source();

DCHECK_EQ(source.type(), blink::WebMediaStreamSource::TypeAudio);

if (source.remote()) {